Skip to content

Commit

Permalink
Merge pull request eclipse-iceoryx#271 from elfenpiff/iox2-270-merge-…
Browse files Browse the repository at this point in the history
…iox2-with-node

[eclipse-iceoryx#270] merge iox2 with node
  • Loading branch information
elfenpiff committed Jul 10, 2024
2 parents 0a852fe + 5d49071 commit 46f8b60
Show file tree
Hide file tree
Showing 19 changed files with 126 additions and 139 deletions.
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {

let publisher = service.publisher_builder().create()?;

while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
let sample = publisher.loan_uninit()?;
let sample = sample.write_payload(1234);
sample.send()?;
Expand All @@ -123,7 +123,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {

let subscriber = service.subscriber_builder().create()?;

while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
while let Some(sample) = subscriber.receive()? {
println!("received: {:?}", *sample);
}
Expand Down Expand Up @@ -172,7 +172,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
let notifier = event.notifier_builder().create()?;

let id = EventId::new(12);
while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
notifier.notify_with_custom_event_id(id)?;

println!("Trigger event with id {:?} ...", id);
Expand All @@ -199,7 +199,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {

let listener = event.listener_builder().create()?;

while let Iox2Event::Tick = Iox2::wait(Duration::ZERO) {
while let NodeEvent::Tick = node.wait(Duration::ZERO) {
if let Ok(Some(event_id)) = listener.timed_wait_one(CYCLE_TIME) {
println!("event was triggered with id: {:?}", event_id);
}
Expand All @@ -226,7 +226,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {

let listener = event.listener_builder().create()?;

while let Iox2Event::Tick = Iox2::wait(Duration::ZERO) {
while let NodeEvent::Tick = node.wait(Duration::ZERO) {
listener.timed_wait_all(
|event_id| {
println!("event was triggered with id: {:?}", event_id);
Expand Down
16 changes: 16 additions & 0 deletions doc/release-notes/iceoryx2-unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
* Updated all dependencies and increased MSRV to 1.75 [#221](https://github.com/eclipse-iceoryx/iceoryx2/issues/221)
* Remove `Service::does_exist_with_custom_config` and `Service::list_with_custom_config` [#238](https://github.com/eclipse-iceoryx/iceoryx2/issues/238)
* Renamed `PortFactory::{publisher|subscriber|listener|notifier}` to `PortFactory::{publisher|subscriber|listener|notifier}_builder` [#244](https://github.com/eclipse-iceoryx/iceoryx2/issues/244)
* Merged `Iox2::wait` with new `Node` and removed `Iox2` [#270](https://github.com/eclipse-iceoryx/iceoryx2/issues/270)

### Workflow

Expand Down Expand Up @@ -355,3 +356,18 @@
pubsub_service.static_config().max_subscriber();
```

17. `Iox2::wait()` is part of the `Node`, `Iox2Event` renamed to `NodeEvent`

```rust
// old
while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
// main loop stuff
}

// new
let node = NodeBuilder::new().create::<zero_copy::Service>()?;
while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
// main loop stuff
}
```

2 changes: 1 addition & 1 deletion examples/rust/complex_data_types/complex_data_types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
let subscriber = service.subscriber_builder().create()?;
let mut counter = 0;

while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
// ComplexDataType as a size of over 30MB, we need to perform a placement new
// otherwise we will encounter a stack overflow in debug builds.
// Therefore, we acquire an uninitialized sample, use the PlacementDefault
Expand Down
2 changes: 1 addition & 1 deletion examples/rust/event/listener.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {

let listener = event.listener_builder().create()?;

while let Iox2Event::Tick = Iox2::wait(Duration::ZERO) {
while let NodeEvent::Tick = node.wait(Duration::ZERO) {
if let Ok(Some(event_id)) = listener.timed_wait_one(CYCLE_TIME) {
println!("event was triggered with id: {:?}", event_id);
}
Expand Down
2 changes: 1 addition & 1 deletion examples/rust/event/notifier.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
let notifier = event.notifier_builder().create()?;

let mut counter: usize = 0;
while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
counter += 1;
notifier.notify_with_custom_event_id(EventId::new(counter))?;

Expand Down
2 changes: 1 addition & 1 deletion examples/rust/publish_subscribe/publisher.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {

let mut counter: u64 = 0;

while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
counter += 1;
let sample = publisher.loan_uninit()?;

Expand Down
2 changes: 1 addition & 1 deletion examples/rust/publish_subscribe/subscriber.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {

let subscriber = service.subscriber_builder().create()?;

while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
while let Some(sample) = subscriber.receive()? {
println!("received: {:?}", *sample);
}
Expand Down
2 changes: 1 addition & 1 deletion examples/rust/publish_subscribe_dynamic_data/publisher.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {

let mut counter = 1;

while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
counter += 1;

let required_memory_size = (8 + counter) % 16;
Expand Down
2 changes: 1 addition & 1 deletion examples/rust/publish_subscribe_dynamic_data/subscriber.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {

let subscriber = service.subscriber_builder().create()?;

while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
while let Some(sample) = subscriber.receive()? {
print!("received {} bytes: ", sample.payload().len());
for byte in sample.payload() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {

let mut counter: u64 = 0;

while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
counter += 1;
let mut sample = publisher.loan_uninit()?;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {

let subscriber = service.subscriber_builder().create()?;

while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
while let Some(sample) = subscriber.receive()? {
println!(
"received: {:?}, user_header: {:?}",
Expand Down
2 changes: 1 addition & 1 deletion examples/rust/service_attributes/creator.rs
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
println!("{} = {}", attribute.key(), attribute.value());
}

while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
let sample = publisher.loan_uninit()?;
let sample = sample.write_payload(0);
sample.send()?;
Expand Down
2 changes: 1 addition & 1 deletion examples/rust/service_attributes/opener.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {

println!("defined service attributes: {:?}", service.attributes());

while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
while let Some(sample) = subscriber.receive()? {
println!("received: {:?}", *sample);
}
Expand Down
2 changes: 1 addition & 1 deletion iceoryx2-ffi/ffi/src/publisher.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ pub extern "C" fn run_publisher(seconds: u32) -> i32 {

let mut remaining_seconds = seconds;

while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
counter += 1;
let sample = publisher.loan_uninit();

Expand Down
2 changes: 1 addition & 1 deletion iceoryx2-ffi/ffi/src/subscriber.rs
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ pub extern "C" fn run_subscriber(seconds: u32) -> i32 {

let mut remaining_seconds = seconds;

while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
loop {
match subscriber.receive() {
Ok(Some(sample)) => println!("received: {:?}", *sample),
Expand Down
111 changes: 0 additions & 111 deletions iceoryx2/src/iox2.rs

This file was deleted.

11 changes: 4 additions & 7 deletions iceoryx2/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
//!
//! let subscriber = service.subscriber_builder().create()?;
//!
//! while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
//! while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
//! while let Some(sample) = subscriber.receive()? {
//! println!("received: {:?}", *sample);
//! }
Expand All @@ -102,7 +102,7 @@
//!
//! let publisher = service.publisher_builder().create()?;
//!
//! while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
//! while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
//! let sample = publisher.loan_uninit()?;
//! let sample = sample.write_payload(1234);
//! sample.send()?;
Expand Down Expand Up @@ -135,7 +135,7 @@
//!
//! let mut listener = event.listener_builder().create()?;
//!
//! while let Iox2Event::Tick = Iox2::wait(Duration::ZERO) {
//! while let NodeEvent::Tick = node.wait(Duration::ZERO) {
//! if let Ok(Some(event_id)) = listener.timed_wait_one(CYCLE_TIME) {
//! println!("event was triggered with id: {:?}", event_id);
//! }
Expand Down Expand Up @@ -163,7 +163,7 @@
//! let notifier = event.notifier_builder().create()?;
//!
//! let mut counter: usize = 0;
//! while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
//! while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
//! counter += 1;
//! notifier.notify_with_custom_event_id(EventId::new(counter))?;
//!
Expand Down Expand Up @@ -289,9 +289,6 @@ mod compiletests;
/// Handles iceoryx2s global configuration
pub mod config;

/// Central instance that handles all incoming events, the event loop
pub mod iox2;

/// Central instance that owns all service entities and can handle incoming event in an event loop
pub mod node;

Expand Down
Loading

0 comments on commit 46f8b60

Please sign in to comment.