Skip to content

Commit

Permalink
[eclipse-iceoryx#270] Add release note; adjust documentation
Browse files Browse the repository at this point in the history
  • Loading branch information
elfenpiff committed Jul 9, 2024
1 parent cccfa0c commit 5d49071
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 10 deletions.
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {

let publisher = service.publisher_builder().create()?;

while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
let sample = publisher.loan_uninit()?;
let sample = sample.write_payload(1234);
sample.send()?;
Expand All @@ -123,7 +123,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {

let subscriber = service.subscriber_builder().create()?;

while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
while let Some(sample) = subscriber.receive()? {
println!("received: {:?}", *sample);
}
Expand Down Expand Up @@ -172,7 +172,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
let notifier = event.notifier_builder().create()?;

let id = EventId::new(12);
while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
notifier.notify_with_custom_event_id(id)?;

println!("Trigger event with id {:?} ...", id);
Expand All @@ -199,7 +199,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {

let listener = event.listener_builder().create()?;

while let Iox2Event::Tick = Iox2::wait(Duration::ZERO) {
while let NodeEvent::Tick = node.wait(Duration::ZERO) {
if let Ok(Some(event_id)) = listener.timed_wait_one(CYCLE_TIME) {
println!("event was triggered with id: {:?}", event_id);
}
Expand All @@ -226,7 +226,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {

let listener = event.listener_builder().create()?;

while let Iox2Event::Tick = Iox2::wait(Duration::ZERO) {
while let NodeEvent::Tick = node.wait(Duration::ZERO) {
listener.timed_wait_all(
|event_id| {
println!("event was triggered with id: {:?}", event_id);
Expand Down
16 changes: 16 additions & 0 deletions doc/release-notes/iceoryx2-unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
* Updated all dependencies and increased MSRV to 1.75 [#221](https://github.com/eclipse-iceoryx/iceoryx2/issues/221)
* Remove `Service::does_exist_with_custom_config` and `Service::list_with_custom_config` [#238](https://github.com/eclipse-iceoryx/iceoryx2/issues/238)
* Renamed `PortFactory::{publisher|subscriber|listener|notifier}` to `PortFactory::{publisher|subscriber|listener|notifier}_builder` [#244](https://github.com/eclipse-iceoryx/iceoryx2/issues/244)
* Merged `Iox2::wait` with new `Node` and removed `Iox2` [#270](https://github.com/eclipse-iceoryx/iceoryx2/issues/270)

### Workflow

Expand Down Expand Up @@ -355,3 +356,18 @@
pubsub_service.static_config().max_subscriber();
```

17. `Iox2::wait()` is part of the `Node`, `Iox2Event` renamed to `NodeEvent`

```rust
// old
while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
// main loop stuff
}

// new
let node = NodeBuilder::new().create::<zero_copy::Service>()?;
while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
// main loop stuff
}
```

8 changes: 4 additions & 4 deletions iceoryx2/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
//!
//! let subscriber = service.subscriber_builder().create()?;
//!
//! while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
//! while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
//! while let Some(sample) = subscriber.receive()? {
//! println!("received: {:?}", *sample);
//! }
Expand All @@ -102,7 +102,7 @@
//!
//! let publisher = service.publisher_builder().create()?;
//!
//! while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
//! while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
//! let sample = publisher.loan_uninit()?;
//! let sample = sample.write_payload(1234);
//! sample.send()?;
Expand Down Expand Up @@ -135,7 +135,7 @@
//!
//! let mut listener = event.listener_builder().create()?;
//!
//! while let Iox2Event::Tick = Iox2::wait(Duration::ZERO) {
//! while let NodeEvent::Tick = node.wait(Duration::ZERO) {
//! if let Ok(Some(event_id)) = listener.timed_wait_one(CYCLE_TIME) {
//! println!("event was triggered with id: {:?}", event_id);
//! }
Expand Down Expand Up @@ -163,7 +163,7 @@
//! let notifier = event.notifier_builder().create()?;
//!
//! let mut counter: usize = 0;
//! while let Iox2Event::Tick = Iox2::wait(CYCLE_TIME) {
//! while let NodeEvent::Tick = node.wait(CYCLE_TIME) {
//! counter += 1;
//! notifier.notify_with_custom_event_id(EventId::new(counter))?;
//!
Expand Down
2 changes: 1 addition & 1 deletion iceoryx2/src/node/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,7 @@ impl<Service: service::Service> Node<Service> {
}

/// Waits until an event was received. It returns
/// [`Iox2Event::Tick`] when the `cycle_time` has passed, otherwise event that occurred.
/// [`NodeEvent::Tick`] when the `cycle_time` has passed, otherwise event that occurred.
pub fn wait(&self, cycle_time: Duration) -> NodeEvent {
if SignalHandler::termination_requested() {
return NodeEvent::TerminationRequest;
Expand Down

0 comments on commit 5d49071

Please sign in to comment.