feat: aurora datadog enable flags #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansenk
force-pushed
the
jkantor/aurora-dd-enable-flags
branch
from
6a0fe4b
to
7ffbc53
Compare
timmc-edx
reviewed
Jun 12, 2024
| @@ -15,7 +15,7 @@ | |||
| - install:app-requirements | |||
|
|
|||
| - name: "Install Datadog APM requirements" | |||
| when: COMMON_ENABLE_DATADOG and COMMON_ENABLE_DATADOG_APP | |||
| when: XQWATCHER_DATADOG_ENABLED | |||
There was a problem hiding this comment.
Some instances in this file are ENABLED instead of ENABLE.
There was a problem hiding this comment.
oh whew thank you for catching this 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired with https://github.com/edx/edx-internal/pull/11048
Make sure that the following steps are done before merging: