Skip to content

Commit 7ffbc53

Browse files
committed
feat: allow xqwatcher dd to be intependently toggled
1 parent a882753 commit 7ffbc53

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

playbooks/roles/xqwatcher/defaults/main.yml

+2
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,8 @@ XQWATCHER_NEWRELIC_APPNAME: "{{ COMMON_DEPLOYMENT }}-{{ COMMON_ENVIRONMENT }}-xq
7676
XQWATCHER_PIP_EXTRA_ARGS: "-i {{ COMMON_PYPI_MIRROR_URL }}"
7777

7878
XQWATCHER_DATADOG_APPNAME: "edx-{{ xqwatcher_service_name }}"
79+
XQWATCHER_DATADOG_ENABLED: "{{COMMON_ENABLE_DATADOG and COMMON_ENABLE_DATADOG_APP}}"
80+
7981
#
8082
#
8183
# vars are namespace with the module name.

playbooks/roles/xqwatcher/tasks/deploy_watcher.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
- install:app-requirements
1616

1717
- name: "Install Datadog APM requirements"
18-
when: COMMON_ENABLE_DATADOG and COMMON_ENABLE_DATADOG_APP
18+
when: XQWATCHER_DATADOG_ENABLED
1919
pip:
2020
name:
2121
- ddtrace

playbooks/roles/xqwatcher/templates/edx/app/supervisor/conf.d/xqwatcher.conf.j2

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
{% else %}
99
{% set executable = xqwatcher_venv_dir + '/bin/python' %}
1010
{% endif %}
11-
{% if COMMON_ENABLE_DATADOG and COMMON_ENABLE_DATADOG_APP %}
11+
{% if XQWATCHER_DATADOG_ENABLED %}
1212
{% set executable = xqwatcher_venv_dir + '/bin/ddtrace-run ' + executable %}
1313
{% endif -%}
1414

@@ -21,6 +21,6 @@ stdout_logfile={{ supervisor_log_dir }}/%(program_name)s-stdout.log
2121
stderr_logfile={{ supervisor_log_dir }}/%(program_name)s-stderr.log
2222
# Copied DD_TRACE_LOG_STREAM_HANDLER config from edx_django_service. This is required
2323
# to disable Datadog trace debug logging.
24-
environment={% if COMMON_ENABLE_NEWRELIC_APP %}NEW_RELIC_APP_NAME={{ XQWATCHER_NEWRELIC_APPNAME }},NEW_RELIC_LICENSE_KEY={{ NEWRELIC_LICENSE_KEY }},{% endif -%}{% if COMMON_ENABLE_DATADOG and COMMON_ENABLE_DATADOG_APP %}DD_DJANGO_USE_HANDLER_RESOURCE_FORMAT=true,DD_TAGS="service:{{ XQWATCHER_DATADOG_APPNAME }} version:{{ app_version }}",DD_TRACE_LOG_STREAM_HANDLER=false,DD_PROFILING_ENABLED=true,DD_DATA_STREAMS_ENABLED=true,{% endif -%}
24+
environment={% if COMMON_ENABLE_NEWRELIC_APP %}NEW_RELIC_APP_NAME={{ XQWATCHER_NEWRELIC_APPNAME }},NEW_RELIC_LICENSE_KEY={{ NEWRELIC_LICENSE_KEY }},{% endif -%}{% if XQWATCHER_DATADOG_ENABLED %}DD_DJANGO_USE_HANDLER_RESOURCE_FORMAT=true,DD_TAGS="service:{{ XQWATCHER_DATADOG_APPNAME }} version:{{ app_version }}",DD_TRACE_LOG_STREAM_HANDLER=false,DD_PROFILING_ENABLED=true,DD_DATA_STREAMS_ENABLED=true,{% endif -%}
2525
killasgroup=true
2626
stopasgroup=true

0 commit comments

Comments
 (0)