Check is_blk_alloced and use free_blk_now during log replay.#144
Merged
Check is_blk_alloced and use free_blk_now during log replay.#144
Conversation
sanebay
force-pushed
the
is_blk_alloc
branch
3 times, most recently
from
c3c94e0 to
3c194a0
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
===========================================
- Coverage 61.68% 47.06% -14.63%
===========================================
Files 15 16 +1
Lines 462 1124 +662
Branches 35 539 +504
===========================================
+ Hits 285 529 +244
- Misses 158 226 +68
- Partials 19 369 +350 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shosseinimotlagh
previously approved these changes
Feb 4, 2026
Contributor
shosseinimotlagh
left a comment
shosseinimotlagh
left a comment
There was a problem hiding this comment.
LGTM with one suggestion
For same lba if there are multiple writes, we free the old blkid's. If those free blkid's are reused and freed again there will be multiple log entries. So during log replay check if they are alloced and if alloced directly free the blk from blk allocator bitmap cache.
shosseinimotlagh
approved these changes
Feb 4, 2026
shosseinimotlagh
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For same lba if there are multiple writes, we free the old blkid's. If those free blkid's are reused and freed again there will be multiple log entries. So during log replay check if they are alloced and if alloced directly
free the blk from blk allocator bitmap cache.
To reproduce the issue
test_volume_io --gtest_filter="VolumeIOTest.LongRunningRandomIO" --num_restarts=4 --num_vols=32 --write_num_io=300 --read_num_io=300 --dev_size_mb=1024000 --log_mods blkalloc:debug --run_time=300