-
Notifications
You must be signed in to change notification settings - Fork 24
Add isblk alloced and free_blk_now api in dataservice. #826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #826 +/- ##
==========================================
- Coverage 56.51% 48.23% -8.28%
==========================================
Files 108 110 +2
Lines 10300 12855 +2555
Branches 1402 6170 +4768
==========================================
+ Hits 5821 6201 +380
+ Misses 3894 2565 -1329
- Partials 585 4089 +3504 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shosseinimotlagh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please explain the problem thoroughly (with an example and UT command to verify) in the pr comment and how this pr solves the problem.
During replay nublocks needs to check if blks are alloced and call free_blk_now to directly free the blks from bitmap cache and not depend on cp flush.
This PR is needed for eBay/HomeBlocks#144. Details are there in that PR. We cant write UT to repro but its reproduced with long running. |
During replay nublocks needs to check if blks are alloced and call free_blk_now to directly free the blks from bitmap cache and not depend on cp flush.
This PR is needed for eBay/HomeBlocks#144. Details are there in that PR. We cant write UT to repro but its reproduced with long running.
test_volume_io --gtest_filter="VolumeIOTest.LongRunningRandomIO" --num_restarts=4 --num_vols=32 --write_num_io=300 --read_num_io=300 --dev_size_mb=1024000 --log_mods blkalloc:debug --run_time=300