Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More <simple-condition> cleanups #1615

Merged
merged 6 commits into from
Jun 15, 2024
Merged

Commits on Jun 12, 2024

  1. Configuration menu
    Copy the full SHA
    e4fe267 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. common-dylan-test-suite: fix tests for <simple-condition>

    * `make-condition(<condition>)` shouldn't pass `format-string:` and
      `format-arguments:` when creating the condition. Added a new method on
      `<simple-condition>` to do that.
    
    * Consolidate testing of `condition-format-string` and
      `condition-format-arguments` into `test-condition(<simple-condition>)` instead
      of duplicating it for each subclass. These tests don't work for `<type-error>`
      because its format string and args are computed from its type and value slots,
      so add `test-condition(<type-error>)` to prevent calling the next method.
    
    * Remove `do-test-type-error-*` functions. I don't think there's anything much
      to test for `<type-error>`, or most condition classes for that matter, since
      they tend to be plain-old-data classes.
    cgay committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    cba3026 View commit details
    Browse the repository at this point in the history
  2. Replace uses of <format-string-condition> with <simple-condition>

    We're choosing one name for the class and it will be <simple-condition>.
    cgay committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    504a229 View commit details
    Browse the repository at this point in the history
  3. Use <simple-error> and <simple-warning> where appropriate

    Replaces superclass lists like `(<error>, <simple-condition>)` with just
    `(<simple-error>)`, and similarly for warnings, where the subclass doesn't need
    to be abstract.
    cgay committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    5602556 View commit details
    Browse the repository at this point in the history
  4. Deprecate <format-string-condition>

    Use <simple-condition> instead. There's no point having two names for one class.
    cgay committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    cb5eb09 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1102acb View commit details
    Browse the repository at this point in the history