More <simple-condition> cleanups #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `make-condition(<condition>)` shouldn't pass `format-string:` and `format-arguments:` when creating the condition. Added a new method on `<simple-condition>` to do that. * Consolidate testing of `condition-format-string` and `condition-format-arguments` into `test-condition(<simple-condition>)` instead of duplicating it for each subclass. These tests don't work for `<type-error>` because its format string and args are computed from its type and value slots, so add `test-condition(<type-error>)` to prevent calling the next method. * Remove `do-test-type-error-*` functions. I don't think there's anything much to test for `<type-error>`, or most condition classes for that matter, since they tend to be plain-old-data classes.
We're choosing one name for the class and it will be <simple-condition>.
Replaces superclass lists like `(<error>, <simple-condition>)` with just `(<simple-error>)`, and similarly for warnings, where the subclass doesn't need to be abstract.
Use <simple-condition> instead. There's no point having two names for one class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<format-string-condition>and replace uses of it with<simple-condition>.<simple-error>in some superclass lists where(<error>, <simple-condition>)was used.