Skip to content

Subscription webview go back action #6752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2025
Merged

Subscription webview go back action #6752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions ...s-impl/src/main/java/com/duckduckgo/subscriptions/impl/ui/SubscriptionsWebViewActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ class SubscriptionsWebViewActivity : DuckDuckGoActivity(), DownloadConfirmationD
newProgress: Int,
) {
if (newProgress == 100) {
if (binding.webview.canGoBack()) {
if (canGoBack()) {
toolbar.setNavigationIcon(R.drawable.ic_arrow_left_24)
} else {
toolbar.setNavigationIcon(R.drawable.ic_close_24)
Expand Down Expand Up @@ -616,8 +616,20 @@ class SubscriptionsWebViewActivity : DuckDuckGoActivity(), DownloadConfirmationD
return super.onOptionsItemSelected(item)
}

override fun onBackPressed() {
private fun canGoBack(): Boolean {
if (binding.webview.canGoBack()) {
binding.webview.url?.let { url ->
val uri = url.toUri()
return uri.getQueryParameter("preventBackNavigation") != "true"
}
return false
} else {
return false
}
}

override fun onBackPressed() {
if (canGoBack()) {
binding.webview.goBack()
} else {
super.onBackPressed()
Expand Down
Loading