Skip to content

Conversation

marcosholgado
Copy link
Contributor

@marcosholgado marcosholgado commented Sep 5, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211073283656160?focus=true

Description

This PR changes the way navigating back works letting the FE decide in some cases when it can and cannot happen

Steps to test this PR

  • Apply the staging patch and VPN into US
  • Go to https://duckduckgo.com/pro?featurePage=stripe
  • Complete the purchase using the test cards for Stripe
  • On the welcome screen, the icon should be a cross rather than an arrow.
  • Pressing either the cross or the back button should take you back to settings (doing this on develop would take you back to Stripe)
  • Now that you are subscribe go to settings and click on "Need help with your subscription"
  • On that webview navigate to some links, see how the cross turns into an arrow and if you now press it or use the back button you navigate back rather than close the screen.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@marcosholgado marcosholgado force-pushed the feature/marcos/subscription_go_back branch from b80897e to 5c2628a Compare September 5, 2025 16:06
Copy link
Contributor

@nalcalag nalcalag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! However, I noticed a few scenarios where the “X” appears instead of the arrow, and I’m not sure if this is intended:

  1. Paywall screen –> On the second step, it still shows the cross instead of the arrow.
    https://github.com/user-attachments/assets/2e7d6084-b03b-4978-a60b-aa08068d439f

  2. Add subscription with email –> In some steps, the cross is replaced by the arrow, but not consistently.
    https://github.com/user-attachments/assets/5c9aae0d-09b5-4829-9bac-602d91619870
    I assume this happens because we’re listening to a query parameter in the URL, so it’s not really coming from our code, but just double-checking to confirm.

@marcosholgado marcosholgado merged commit 8ae2523 into develop Sep 9, 2025
13 checks passed
@marcosholgado marcosholgado deleted the feature/marcos/subscription_go_back branch September 9, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants