Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic tests for the currently supported types #23

Merged
merged 20 commits into from
May 29, 2024
+1,127 −25
Merged

Add basic tests for the currently supported types #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
094afc1
add basic tests for the supported types
Tishj Apr 29, 2024
3fb6598
missing drop for chr
Tishj Apr 29, 2024
8bf0eba
missing drop echo
Tishj May 6, 2024
fcec38e
numerics without bounds get converted to double, properly detect and …
Tishj May 6, 2024
0bbc240
convert NUMERIC to DOUBLE
Tishj May 6, 2024
cedd577
detect that the NUMERIC was converted to a DOUBLE, treat it as such
Tishj May 6, 2024
16767ac
distinguish numeric error message
Tishj May 12, 2024
b6a79e1
add float4 and float8 tests
Tishj May 12, 2024
50ba4f8
add tests for a NUMERIC column that is converted as a DOUBLE because …
Tishj May 12, 2024
5e7513f
make sure the quack extension is loaded in the type test, add support…
Tishj May 13, 2024
1255e15
merge with main, fix up tests for hugeint decimals
Tishj May 17, 2024
fa8ceb2
fix FLOAT4OID
Tishj May 17, 2024
7da0e22
fix timestamp conversion, update type_support.out
Tishj May 22, 2024
86352d8
add UUID type support
Tishj May 22, 2024
dfdf769
add JSON type support
Tishj May 22, 2024
238aa20
Merge branch 'main' into type_support_tests
Tishj May 27, 2024
78d66cf
fix up tests and compilation (uint64 -> uint64_t)
Tishj May 27, 2024
32d0d8a
missing include
Tishj May 28, 2024
a342780
Merge branch 'main' into type_support_tests
Tishj May 29, 2024
759d0d8
undo changes to makefile
Tishj May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,15 @@ third_party/duckdb/Makefile:
git submodule update --init --recursive

third_party/duckdb/build/$(QUACK_BUILD_DUCKDB)/src/$(DUCKDB_LIB):
$(MAKE) -C third_party/duckdb $(QUACK_BUILD_DUCKDB) DISABLE_SANITIZER=1 ENABLE_UBSAN=0 BUILD_UNITTESTS=OFF BUILD_HTTPFS=1 CMAKE_EXPORT_COMPILE_COMMANDS=1 -j8
$(MAKE) -C third_party/duckdb \
$(QUACK_BUILD_DUCKDB) \
DISABLE_SANITIZER=1 \
ENABLE_UBSAN=0 \
BUILD_UNITTESTS=OFF \
BUILD_HTTPFS=1 \
BUILD_JSON=1 \
CMAKE_EXPORT_COMPILE_COMMANDS=1 \
-j8

install-duckdb:
$(install_bin) -m 755 third_party/duckdb/build/$(QUACK_BUILD_DUCKDB)/src/$(DUCKDB_LIB) $(DESTDIR)$(PG_LIB)
Expand Down
4 changes: 2 additions & 2 deletions include/quack/quack_types.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ namespace quack {
constexpr int32_t QUACK_DUCK_DATE_OFFSET = 10957;
constexpr int64_t QUACK_DUCK_TIMESTAMP_OFFSET = INT64CONST(10957) * USECS_PER_DAY;

duckdb::LogicalType ConvertPostgresToDuckColumnType(Oid type);
Oid GetPostgresDuckDBType(duckdb::LogicalTypeId type);
duckdb::LogicalType ConvertPostgresToDuckColumnType(Oid type, int32_t typmod);
Oid GetPostgresDuckDBType(duckdb::LogicalType type);
void ConvertPostgresToDuckValue(Datum value, duckdb::Vector &result, idx_t offset);
void ConvertDuckToPostgresValue(TupleTableSlot *slot, duckdb::Value &value, idx_t col);
void InsertTupleIntoChunk(duckdb::DataChunk &output, PostgresHeapSeqScanThreadInfo &threadScanInfo,
Expand Down
Loading