Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic tests for the currently supported types #23

Merged
merged 20 commits into from
May 29, 2024
Merged

Add basic tests for the currently supported types #23

merged 20 commits into from
May 29, 2024

Conversation

Tishj
Copy link
Collaborator

@Tishj Tishj commented Apr 29, 2024

Adding tests for the currently supported types:

  • CHAR
  • SMALLINT
  • INTEGER
  • BIGINT
  • DATE
  • TIMESTAMP
  • VARCHAR

Tishj added 15 commits April 29, 2024 12:27
@Tishj
add basic tests for the supported types
094afc1
@Tishj
missing drop for chr
3fb6598
@Tishj
missing drop echo
8bf0eba
@Tishj
numerics without bounds get converted to double, properly detect and …
fcec38e 
…propagate this information
@Tishj
convert NUMERIC to DOUBLE
0bbc240
@Tishj
detect that the NUMERIC was converted to a DOUBLE, treat it as such
cedd577
@Tishj
distinguish numeric error message
16767ac
@Tishj
add float4 and float8 tests
b6a79e1
@Tishj
add tests for a NUMERIC column that is converted as a DOUBLE because …
50ba4f8 
…no typmod is present
@Tishj
make sure the quack extension is loaded in the type test, add support…
5e7513f 
… for DECIMALs
@Tishj
merge with main, fix up tests for hugeint decimals
1255e15
@Tishj
fix FLOAT4OID
fa8ceb2
@Tishj
fix timestamp conversion, update type_support.out
7da0e22
@Tishj
add UUID type support
86352d8
@Tishj
add JSON type support
dfdf769
@wuputah
Copy link
Collaborator

wuputah commented May 24, 2024

can we wrap up this PR, merge it, and open a new PR for any add'l types we are adding?

@Tishj
Copy link
Collaborator Author

Tishj commented May 28, 2024 •
edited
Loading

@wuputah CI is passing 👍
Feel free to merge it whenever

@mkaruza
Copy link
Collaborator

mkaruza commented May 28, 2024

@Tishj can we merge #35 first so you can base testing after that. Probably that will require that you only copy/paste sql and result file and add test to schedule.
Also after #35 PR is merged you will not need anymore create extension and drop extension anymore.

@Tishj
Copy link
Collaborator Author

Tishj commented May 29, 2024

@wuputah should be ready to merge

@mkaruza mkaruza self-requested a review May 29, 2024 13:26
@mkaruza mkaruza merged commit 495e3d9 into main May 29, 2024
2 checks passed
@mkaruza mkaruza deleted the type_support_tests branch May 29, 2024 13:29
@wuputah wuputah added this to the 0.1.0 milestone May 31, 2024
@wuputah wuputah mentioned this pull request May 31, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaruza mkaruza mkaruza approved these changes

Assignees

@Tishj Tishj

Labels
None yet
Projects
pg_duckdb
Status: Done
Milestone
0.1.0 code complete
Development

Successfully merging this pull request may close these issues.
3 participants
@Tishj @wuputah @mkaruza