Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PictureBox tests and fix bugs #1355

Merged
merged 4 commits into from
Jul 29, 2019
Merged

Conversation

hughbe
Copy link
Contributor

@hughbe hughbe commented Jul 12, 2019

Fixes #1310

@hughbe hughbe requested a review from a team as a code owner July 12, 2019 12:25
Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs merge

@hughbe hughbe force-pushed the picturebox-tests branch 2 times, most recently from 5b40c83 to 36d95f7 Compare July 19, 2019 07:40
@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #1355 into master will increase coverage by 13.1269%.
The diff coverage is 96.60088%.

@@                 Coverage Diff                 @@
##              master       #1355         +/-   ##
===================================================
+ Coverage   25.08146%   38.20836%   +13.1269%     
===================================================
  Files            785        1127        +342     
  Lines         268553      333236      +64683     
  Branches       37959       39046       +1087     
===================================================
+ Hits           67357      127324      +59967     
- Misses        196455      201240       +4785     
+ Partials        4741        4672         -69
Flag Coverage Δ
#Debug 38.20836% <96.60088%> (+13.1269%) ⬆️
#production 24.02551% <47.91667%> (-1.05595%) ⬇️
#test 98.78051% <99.30556%> (-1.21949%) ⬇️

@RussKie RussKie added design-discussion Ongoing discussion about design without consensus needs-more-info labels Jul 19, 2019
@hughbe hughbe force-pushed the picturebox-tests branch 3 times, most recently from 93c451b to 134e0a4 Compare July 22, 2019 09:00
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stylistic comments

@ghost ghost added the 📭 waiting-author-feedback The team requires more information from the author label Jul 29, 2019
@RussKie RussKie removed design-discussion Ongoing discussion about design without consensus needs-more-info labels Jul 29, 2019
@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Jul 29, 2019
@RussKie RussKie merged commit afef499 into dotnet:master Jul 29, 2019
@hughbe hughbe deleted the picturebox-tests branch July 29, 2019 14:59
@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PictureBox.OnPaint(null) if PictureBox has image throws NRE
4 participants