-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PictureBox tests and fix bugs #1355
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmoseley
reviewed
Jul 18, 2019
danmoseley
approved these changes
Jul 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but needs merge
hughbe
force-pushed
the
picturebox-tests
branch
2 times, most recently
from
July 19, 2019 07:40
5b40c83
to
36d95f7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1355 +/- ##
===================================================
+ Coverage 25.08146% 38.20836% +13.1269%
===================================================
Files 785 1127 +342
Lines 268553 333236 +64683
Branches 37959 39046 +1087
===================================================
+ Hits 67357 127324 +59967
- Misses 196455 201240 +4785
+ Partials 4741 4672 -69
|
RussKie
added
design-discussion
Ongoing discussion about design without consensus
needs-more-info
labels
Jul 19, 2019
hughbe
force-pushed
the
picturebox-tests
branch
3 times, most recently
from
July 22, 2019 09:00
93c451b
to
134e0a4
Compare
RussKie
requested changes
Jul 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stylistic comments
src/System.Windows.Forms/src/System/Windows/Forms/PictureBox.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/PictureBox.cs
Outdated
Show resolved
Hide resolved
ghost
added
the
📭 waiting-author-feedback
The team requires more information from the author
label
Jul 29, 2019
RussKie
removed
design-discussion
Ongoing discussion about design without consensus
needs-more-info
labels
Jul 29, 2019
ghost
removed
the
📭 waiting-author-feedback
The team requires more information from the author
label
Jul 29, 2019
RussKie
approved these changes
Jul 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1310