Add AccessibleObject tests #2401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughbe
force-pushed
the
AccessibleObject-tests
branch
2 times, most recently
from
1b5d29c
to
ea0fda7
Compare
Codecov Report
@@ Coverage Diff @@
## master #2401 +/- ##
=================================================
+ Coverage 29.04453% 29.24953% +0.205%
=================================================
Files 1003 1003
Lines 259505 259505
Branches 36836 36836
=================================================
+ Hits 75372 75904 +532
+ Misses 179223 178664 -559
- Partials 4910 4937 +27
|
RussKie
reviewed
Nov 21, 2019
src/System.Windows.Forms/src/System/Windows/Forms/AccessibleObject.cs
Outdated
Show resolved
Hide resolved
RussKie
added
📭 waiting-author-feedback
M-Lipin
suggested changes
Nov 21, 2019
src/System.Windows.Forms/src/System/Windows/Forms/AccessibleObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/AccessibleObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/AccessibleObject.cs
Outdated
Show resolved
Hide resolved
|
@hughbe thank you for adding tests! The changes look good to me, please look at few comments above. |
ghost
removed
the
📭 waiting-author-feedback
Thanks for the review. All the Debug.Asserts that I've removed are invalid as they can be hit: each one is tested. |
RussKie
requested changes
Nov 25, 2019
ghost
added
the
📭 waiting-author-feedback
hughbe
force-pushed
the
AccessibleObject-tests
branch
from
ea0fda7
to
4f382bc
Compare
ghost
removed
the
📭 waiting-author-feedback
hughbe
force-pushed
the
AccessibleObject-tests
branch
from
5f5f09a
to
a749af5
Compare
Done |
RussKie
approved these changes
Dec 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Microsoft Reviewers: Open in CodeFlow