Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include test support files in sdist #530

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Include test support files in sdist #530

merged 1 commit into from
Aug 26, 2024

Conversation

bigfootjon
Copy link
Collaborator

Ref: https://setuptools.pypa.io/en/latest/deprecated/distutils/sourcedist.html#specifying-the-files-to-distribute

I also went ahead and started preparing release notes for 4.1.3

Closes: #522

@bigfootjon bigfootjon mentioned this pull request Aug 25, 2024
Closed
carltongibson
carltongibson approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks good. (I didn't actually build the sdist to check…)

@bigfootjon bigfootjon merged commit 862ebcd into main Aug 26, 2024
11 checks passed
@bigfootjon bigfootjon deleted the include-tests branch August 26, 2024 14:02
@bigfootjon
Copy link
Collaborator Author

I didn't actually build the sdist to check

I did! Expected files are present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson carltongibson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing file for tests in pypi distfile
2 participants
@bigfootjon @carltongibson