Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing file for tests in pypi distfile #522

Closed
0-wiz-0 opened this issue Aug 10, 2024 · 4 comments · Fixed by #530
Closed

missing file for tests in pypi distfile #522

0-wiz-0 opened this issue Aug 10, 2024 · 4 comments · Fixed by #530

Comments

@0-wiz-0
Copy link

0-wiz-0 commented Aug 10, 2024

When running the self tests from the pypi distfile, I see:

ImportError while importing test module '/scratch/www/py-daphne/work/daphne-4.1.2/tests/test_websocket.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/pkg/lib/python3.12/importlib/__init__.py:90: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test_websocket.py:5: in <module>
    import http_strategies
E   ModuleNotFoundError: No module named 'http_strategies'

The file http_strategies.py is missing from the pypi (4.1.2) distfile. Please add it.

@bigfootjon
Copy link
Collaborator

@carltongibson how do you feel about including the tests in the pypi package?

@carltongibson
Copy link
Member

@bigfootjon No problem: they're useful for OS package maintainers, who like to run the tests (rightly)

I looked at this briefly: the tests are there, but we're missing the http_base.py and http_strategies.py files from the test folder. (Likely the discovery rule says, begins with test_...)

@bigfootjon
Copy link
Collaborator

see: #530

@0-wiz-0
Copy link
Author

0-wiz-0 commented Aug 26, 2024

Thank you, @bigfootjon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants