Add --output option to pbench-generate-token
#3264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option makes it a bit easier to script the invocation of `pbench-generate-token` where username and/or password prompts are required (the prompt does not get mixed up into the token output).
portante
force-pushed
the
gen-token-output
branch
from
8b859b5 to
0f9ed41
Compare
riya-17
approved these changes
Feb 20, 2023
webbnh
approved these changes
Feb 20, 2023
Comment on lines
+44
to
+45
| with open(self.context.output, "w") as ofp: | ||
| ofp.write(f"{payload['auth_token']}\n") |
There was a problem hiding this comment.
Alternately,
Path(self.context.output).write_text(payload['auth_token'] + '\n')
(Since you used Path.read_text() in the test....)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option makes it a bit easier to script the invocation of
pbench-generate-tokenwhere username and/or password prompts are required (the prompt does not get mixed up into the token output).Separated into its own PR from PR #3259.