Simple example of running pbench agent in a container #3259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webbnh
previously approved these changes
Feb 16, 2023
|
Thanks for the review! PRs to address these and other changes folks would want are welcome! |
webbnh
previously approved these changes
Feb 20, 2023
webbnh
previously approved these changes
Feb 23, 2023
There was a problem hiding this comment.
This looks great (although, I did find one typo, and I have a couple of suggestions).
Perhaps independent of this PR, we should seriously consider setting up the Agent containers with entrypoints which point to a wrapper script which executes /opt/pbench-agent/profile before executing the requested command, so that that environment is always in place for commands run inside the container (and so that we don't have to do it in every script).
ndokos
previously approved these changes
Feb 27, 2023
dbutenhof
previously approved these changes
Mar 3, 2023
We want to make it as easy for the user to do this as possible. The new `README.md` describes the steps, which are just running `./setup.sh` and executing `example-driver.sh`.
dbutenhof
approved these changes
Mar 6, 2023
|
I cleaned up all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this PR assumes the Pbench Agent used includes the work from PR #3264.