Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Save filters in search params #1601

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mbacherycz
Copy link
Contributor

@mbacherycz mbacherycz commented Dec 18, 2024

Essentially filters are now a part of the query parameter schema of the URL.
Only valid filters are read and written to query parameters. The concept of filters being a separate thing than search by it's own query key (filters) does not make sense anymore.

  1. Add filters populates URL with query parameters representing each filter, e.g. "sender=digitaliseringsdirektoratet".
  2. Changing routes between viewType resets the filters, but returning to list, preserves the filters.
  3. Display filters on change party
  4. Refactor Inbox by moving group by logic out to separate hook
  5. Refactor filtering by moving it to useFilters (remove unnecessary useHooks with unwanted side-effects)
  6. Fixes deepEqual checking whether the search was saved already (it was giving false negatives when order of filters where different)

Hva er endret?

Related Issue(s)

#1598

Dokumentasjon / Storybook / testdekning

  • Dokumentasjon er oppdatert eller ikke relevant / nødvendig.
  • Ny komponent har en eller flere stories i Storybook, eller så er ikke dette relevant.
  • Det er blitt lagt til nye tester / eksiterende tester er blitt utvidet, eller tester er ikke relevant.

Skjermbilder eller GIFs (valgfritt)

@mbacherycz mbacherycz added the dev developer task label Dec 18, 2024
@mbacherycz mbacherycz self-assigned this Dec 18, 2024
@mbacherycz mbacherycz requested a review from a team as a code owner December 18, 2024 11:47
Copy link

coderabbitai bot commented Dec 18, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mbacherycz mbacherycz linked an issue Dec 18, 2024 that may be closed by this pull request
@mbacherycz mbacherycz force-pushed the feat/save_filters_in_search_params branch from 14696be to afffb9b Compare December 19, 2024 11:18
@seanes seanes marked this pull request as draft December 20, 2024 11:26
@seanes seanes changed the title draft: feat: Save filters in search params feat: Save filters in search params Dec 20, 2024
@seanes seanes force-pushed the feat/save_filters_in_search_params branch from 71f197e to fa32fca Compare December 20, 2024 11:45
@seanes seanes force-pushed the feat/save_filters_in_search_params branch from 6ba307e to b593d32 Compare December 23, 2024 13:33
@seanes seanes force-pushed the feat/save_filters_in_search_params branch from b593d32 to 693bb3b Compare December 23, 2024 17:30
 Please enter the commit message for your changes. Lines starting
@seanes seanes force-pushed the feat/save_filters_in_search_params branch from 83a986d to 540de87 Compare December 23, 2024 19:12
@seanes seanes self-assigned this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev developer task
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Feat: Preserve Active Filters in URL
2 participants