Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Preserve Active Filters in URL #1598

Open
seanes opened this issue Dec 18, 2024 · 0 comments · May be fixed by #1601
Open

Feat: Preserve Active Filters in URL #1598

seanes opened this issue Dec 18, 2024 · 0 comments · May be fixed by #1601
Assignees

Comments

@seanes
Copy link
Collaborator

seanes commented Dec 18, 2024

Feature Request: Preserve Active Filters in URL

Description:
To maintain a consistent and user-friendly experience, active filters chosen by the end-user should be preserved in the URL. This ensures filters are persistent across page reloads or when bookmarks are saved. Additionally, sensitive data such as party IDs should not be included; instead, names or other non-sensitive identifiers should be used.

Background:
Currently, filters are being utilized as query parameters to rehydrate the filter state (e.g., populate search and filters with pre-selected values) when loading "saved searches." However, once these values are loaded, the filters query parameters are removed from the URL. This approach introduces unwanted side effects and is brittle to maintain.

Furthermore, the URL is not being updated when filters are applied. As a result, reloading the page or manually saving a bookmark does not preserve the active filters.

Proposed Improvements:

  1. Dynamic URL Update:

    • Applying filters should dynamically update the URL to reflect the active filters.
    • This ensures that the current state is easily shareable and bookmarkable.
  2. Persistent Reloads:

    • Reloading the page should load the filters from the URL and rehydrate the state seamlessly.
  3. Context-Aware Filters:

    • Filters that are not applicable for the selected party should be ignored and removed from the URL.
    • Example: If a filter is applied to Party X but the user switches to Party Y, and the filter is not relevant to Party Y’s dialogs, it should not be retained in the active filters.
  4. Retain Query Parameters:

    • After filters are loaded from the URL, the query parameters should remain intact.
    • This prevents unexpected behavior and ensures consistency for users navigating back or refreshing the page.

Acceptance Criteria:

  • The URL should accurately reflect the active filters at all times.
  • Reloading or bookmarking a page with active filters should maintain the filter state.
  • Filters irrelevant to the current party should be excluded from the URL.
  • Query parameters should not be removed after loading filters.
  • Party IDs should be replaced with names or other non-sensitive identifiers in the URL, e.g. for senders and receivers. (This is already in place today).

Technical Notes:

  • Ensure changes are compliant with security standards to avoid exposing sensitive information in the URL.
@mbacherycz mbacherycz linked a pull request Dec 18, 2024 that will close this issue
3 tasks
@mbacherycz mbacherycz linked a pull request Dec 18, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Doing
Development

Successfully merging a pull request may close this issue.

2 participants