Skip to content

Commit

Permalink
👷 Deduplicate Agent Images (#1321)
Browse files Browse the repository at this point in the history
* Governance and Multitenant Agents are technically the exact same
* Only difference is the `acapy-wallet-groups-plugin` and startup
  parameters
* Update Mediator py3.12-1.2.1 -> py3.12-1.2.2
  • Loading branch information
rblaine95 authored Feb 10, 2025
1 parent ba471b6 commit ceb8fb1
Show file tree
Hide file tree
Showing 10 changed files with 20 additions and 39 deletions.
15 changes: 5 additions & 10 deletions .github/workflows/cicd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -150,16 +150,19 @@ jobs:
fail-fast: false
matrix:
image:
- acapy-cloud/agent
- acapy-cloud/app
- acapy-cloud/endorser
- acapy-cloud/governance-agent
- acapy-cloud/ledger-nodes
- acapy-cloud/multitenant-agent
- acapy-cloud/pytest
- acapy-cloud/tails-server
- acapy-cloud/trust-registry
- acapy-cloud/waypoint
include:
- image: acapy-cloud/agent
context: .
file: dockerfiles/agents/Dockerfile
platforms: linux/amd64 # Pending BBS - linux/arm64
- image: acapy-cloud/app
context: .
file: dockerfiles/app/Dockerfile
Expand All @@ -168,18 +171,10 @@ jobs:
context: .
file: dockerfiles/endorser/Dockerfile
platforms: linux/amd64,linux/arm64
- image: acapy-cloud/governance-agent
context: .
file: dockerfiles/agents/Dockerfile.agent
platforms: linux/amd64 # Pending BBS - linux/arm64
- image: acapy-cloud/ledger-nodes
context: https://github.com/bcgov/von-network.git#v1.8.0
file: Dockerfile
platforms: linux/amd64
- image: acapy-cloud/multitenant-agent
context: .
file: dockerfiles/agents/Dockerfile.author.agent
platforms: linux/amd64 # Pending BBS - linux/arm64
- image: acapy-cloud/pytest
context: .
file: dockerfiles/tests/Dockerfile
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ RUN chmod +x ./startup.sh
USER aries

ENTRYPOINT [ "./startup.sh" ]
CMD [ "--wallet-type", "askar", "--auto-promote-author-did", \
"--plugin", "acapy_wallet_groups_plugin", \
"--plugin", "nats_events.v1_0.nats_queue.events", "--plugin-config-value", "nats_queue.connection.connection_url=\"nats://nats-1:4222\""]
## Governance Agent
CMD [ "--wallet-type", "askar", \
"--plugin", "nats_events.v1_0.nats_queue.events", \
## Multitenant Agent
# "--auto-promote-author-did", \
# "--plugin", "acapy_wallet_groups_plugin", \
"--plugin-config-value", "nats_queue.connection.connection_url=\"nats://nats-1:4222\""]
18 changes: 0 additions & 18 deletions dockerfiles/agents/Dockerfile.agent

This file was deleted.

2 changes: 1 addition & 1 deletion helm/acapy-cloud/conf/dev/governance-agent.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ podAnnotations:
ad.datadoghq.com/governance-agent.logs: '[{"source": "python", "service": "governance-agent", "auto_multi_line_detection": true}]'

image:
name: acapy-cloud/governance-agent
name: acapy-cloud/agent
pullPolicy: Always
tag: master

Expand Down
2 changes: 1 addition & 1 deletion helm/acapy-cloud/conf/dev/mediator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ image:
registry: ghcr.io/openwallet-foundation
name: acapy-agent
pullPolicy: Always
tag: py3.12-1.2.1
tag: py3.12-1.2.2

podLabels:
admission.datadoghq.com/enabled: "false"
Expand Down
2 changes: 1 addition & 1 deletion helm/acapy-cloud/conf/dev/multitenant-agent.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ podAnnotations:
ad.datadoghq.com/multitenant-agent.logs: '[{"source": "python", "service": "multitenant-agent", "auto_multi_line_detection": true}]'

image:
name: acapy-cloud/multitenant-agent
name: acapy-cloud/agent
tag: master
pullPolicy: Always

Expand Down
2 changes: 1 addition & 1 deletion helm/acapy-cloud/conf/local/governance-agent.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ podAnnotations:
ad.datadoghq.com/governance-agent.logs: '[{"source": "python", "service": "governance-agent", "auto_multi_line_detection": true}]'

image:
name: acapy-cloud/governance-agent
name: acapy-cloud/agent
pullPolicy: Always
tag: master

Expand Down
2 changes: 1 addition & 1 deletion helm/acapy-cloud/conf/local/mediator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ image:
registry: ghcr.io/openwallet-foundation
name: acapy-agent
pullPolicy: Always
tag: py3.12-1.2.1
tag: py3.12-1.2.2

podLabels:
admission.datadoghq.com/enabled: "false"
Expand Down
2 changes: 1 addition & 1 deletion helm/acapy-cloud/conf/local/multitenant-agent.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ podAnnotations:
ad.datadoghq.com/multitenant-agent.logs: '[{"source": "python", "service": "multitenant-agent", "auto_multi_line_detection": true}]'

image:
name: acapy-cloud/multitenant-agent
name: acapy-cloud/agent
tag: master
pullPolicy: Always

Expand Down
4 changes: 2 additions & 2 deletions tilt/acapy-cloud/Tiltfile
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ def setup_cloudapi(build_enabled, expose):
),
],
"image": {
"dockerfile": "./dockerfiles/agents/Dockerfile.agent",
"dockerfile": "./dockerfiles/agents/Dockerfile",
"ignore": [
"app/**",
"endorser/**",
Expand Down Expand Up @@ -487,7 +487,7 @@ def setup_cloudapi(build_enabled, expose):
),
],
"image": {
"dockerfile": "./dockerfiles/agents/Dockerfile.author.agent",
"dockerfile": "./dockerfiles/agents/Dockerfile",
"ignore": [
"app/**",
"endorser/**",
Expand Down

0 comments on commit ceb8fb1

Please sign in to comment.