Skip to content

Commit

Permalink
🧑‍💻 Expand Tilt ignore patterns (#1320)
Browse files Browse the repository at this point in the history
* Ignore `tests` in Tilt docker builds
* Resolves very annoying issue where modifying tests causes almost
everything to restart
* Also expand the ignore patterns
  * Updating code should only update the affected resource
    * e.g: Modifying `endorser/main.py` should not cause `tenant-web` to roll
  • Loading branch information
rblaine95 authored Feb 10, 2025
1 parent 1fe8f3a commit ba471b6
Show file tree
Hide file tree
Showing 9 changed files with 72 additions and 9 deletions.
3 changes: 1 addition & 2 deletions .dockerignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,9 @@
!app/
!shared/
!endorser/
!scripts/
!trustregistry/
!waypoint/
!scripts/
!configuration/
!LICENSE

**/__pycache__/
3 changes: 2 additions & 1 deletion helm/acapy-cloud/conf/dev/endorser.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ command:
- uvicorn
- endorser.main:app
- --log-config=/tmp/log_conf.yaml
- --reload
- --workers
- 1
- --host
- 0.0.0.0
- --port
Expand Down
3 changes: 2 additions & 1 deletion helm/acapy-cloud/conf/dev/governance-web.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ command:
- uvicorn
- app.main:app
- --log-config=/tmp/log_conf.yaml
- --reload
- --workers
- 1
- --host
- 0.0.0.0
- --port
Expand Down
3 changes: 2 additions & 1 deletion helm/acapy-cloud/conf/dev/multitenant-web.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ command:
- uvicorn
- app.main:app
- --log-config=/tmp/log_conf.yaml
- --reload
- --workers
- 1
- --host
- 0.0.0.0
- --port
Expand Down
3 changes: 2 additions & 1 deletion helm/acapy-cloud/conf/dev/public-web.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ command:
- uvicorn
- app.main:app
- --log-config=/tmp/log_conf.yaml
- --reload
- --workers
- 1
- --host
- 0.0.0.0
- --port
Expand Down
3 changes: 2 additions & 1 deletion helm/acapy-cloud/conf/dev/tenant-web.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ command:
- uvicorn
- app.main:app
- --log-config=/tmp/log_conf.yaml
- --reload
- --workers
- 1
- --host
- 0.0.0.0
- --port
Expand Down
3 changes: 2 additions & 1 deletion helm/acapy-cloud/conf/dev/trust-registry.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ command:
- uvicorn
- trustregistry.main:app
- --log-config=/tmp/log_conf.yaml
- --reload
- --workers
- 1
- --host
- 0.0.0.0
- --port
Expand Down
3 changes: 2 additions & 1 deletion helm/acapy-cloud/conf/dev/waypoint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ command:
- uvicorn
- waypoint.main:app
- --log-config=/tmp/log_conf.yaml
- --reload
- --workers
- 1
- --host
- 0.0.0.0
- --port
Expand Down
57 changes: 57 additions & 0 deletions tilt/acapy-cloud/Tiltfile
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ def build_cloudapi_service(service, image={}):
deps=["./"],
live_update=image.get("live_update", []),
skips_local_docker=True,
ignore=["**/tests/**"] + image.get("ignore", []),
)
return [registry + "/" + service]

Expand Down Expand Up @@ -421,6 +422,12 @@ def setup_cloudapi(build_enabled, expose):
],
enabled=build_enabled,
),
"ignore": [
"app/**",
"scripts/**",
"trustregistry/**",
"waypoint/**",
],
},
},
"governance-agent": {
Expand All @@ -433,6 +440,13 @@ def setup_cloudapi(build_enabled, expose):
],
"image": {
"dockerfile": "./dockerfiles/agents/Dockerfile.agent",
"ignore": [
"app/**",
"endorser/**",
"shared/**",
"trustregistry/**",
"waypoint/**",
],
},
},
"governance-web": {
Expand All @@ -456,6 +470,12 @@ def setup_cloudapi(build_enabled, expose):
],
enabled=build_enabled,
),
"ignore": [
"endorser/**",
"scripts/**",
"trustregistry/**",
"waypoint/**",
],
},
},
"multitenant-agent": {
Expand All @@ -468,6 +488,13 @@ def setup_cloudapi(build_enabled, expose):
],
"image": {
"dockerfile": "./dockerfiles/agents/Dockerfile.author.agent",
"ignore": [
"app/**",
"endorser/**",
"shared/**",
"trustregistry/**",
"waypoint/**",
],
},
},
"multitenant-web": {
Expand All @@ -491,6 +518,12 @@ def setup_cloudapi(build_enabled, expose):
],
enabled=build_enabled,
),
"ignore": [
"endorser/**",
"scripts/**",
"trustregistry/**",
"waypoint/**",
],
},
},
"tenant-web": {
Expand All @@ -510,6 +543,12 @@ def setup_cloudapi(build_enabled, expose):
],
enabled=build_enabled,
),
"ignore": [
"endorser/**",
"scripts/**",
"trustregistry/**",
"waypoint/**",
],
},
},
"public-web": {
Expand All @@ -529,6 +568,12 @@ def setup_cloudapi(build_enabled, expose):
],
enabled=build_enabled,
),
"ignore": [
"endorser/**",
"scripts/**",
"trustregistry/**",
"waypoint/**",
],
},
},
"trust-registry": {
Expand All @@ -551,6 +596,12 @@ def setup_cloudapi(build_enabled, expose):
],
enabled=build_enabled,
),
"ignore": [
"app/**",
"endorser/**",
"scripts/**",
"waypoint/**",
],
},
},
"waypoint": {
Expand All @@ -567,6 +618,12 @@ def setup_cloudapi(build_enabled, expose):
],
enabled=build_enabled,
),
"ignore": [
"app/**",
"endorser/**",
"scripts/**",
"trustregistry/**",
],
},
},
"ledger-browser": {
Expand Down

0 comments on commit ba471b6

Please sign in to comment.