Skip to content

Fixes #81 - missing error information when running examples #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes #81 - missing error information when running examples #82

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a1b4f5
Fixes #81 - missing error information when running examples
gsieling-e84 Jun 26, 2019
5d9b381
Address code review feedback
gsieling-e84 Jun 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/kes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,8 @@ class Kes {
const destPath = path.join(this.config.kesFolder, this.cf_template_name);
console.log(`Template saved to ${destPath}`);
return fs.writeFileSync(destPath, cf);
}).catch((e) => {
console.log(e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we would also want to re-throw the error here or else it would be swallowed when compileCF is called elsewhere, like uploadCF

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I added a throw

});
}

Expand Down
8 changes: 7 additions & 1 deletion src/lambda.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,13 @@ class Lambda {
s3.headObject({
Bucket: this.bucket,
Key: lambda.remote
}).promise().then((data) => {
}).promise().catch(
(e) => {
console.log('Error uploading lambda to: ' + params.Bucket + '/' + params.Key);

throw e;
}
).then((data) => {
if (data.ContentLength !== params.Body.byteLength) {
throw new Error('File sizes don\'t match');
}
Expand Down