Fixes #81 - missing error information when running examples #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdboyd
reviewed
Jun 26, 2019
| @@ -170,6 +170,8 @@ class Kes { | |||
| const destPath = path.join(this.config.kesFolder, this.cf_template_name); | |||
| console.log(`Template saved to ${destPath}`); | |||
| return fs.writeFileSync(destPath, cf); | |||
| }).catch((e) => { | |||
| console.log(e); | |||
There was a problem hiding this comment.
I think we would also want to re-throw the error here or else it would be swallowed when compileCF is called elsewhere, like uploadCF
There was a problem hiding this comment.
Makes sense, I added a throw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets you see the stack traces that come out of the AWS SDK. Unfortunately it doesn't show you the caller because the stack traces stop at the promise boundary.
If I run across another issue like this I'll make another PR - using async/await on the AWS promises might improve things, but that looks like a more involved change..