Initial version of OCI packages for features. #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshspicer
previously approved these changes
Aug 1, 2022
joshspicer
previously approved these changes
Aug 1, 2022
alexdima
requested changes
Aug 2, 2022
alexdima
requested changes
Aug 2, 2022
src/test/container-features/containerFeaturesOCI.offline.test.ts
Outdated
Show resolved
Hide resolved
Merged
|
LGTM |
joshspicer
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code here implements the latest changes to the features proposal as written here:
devcontainers/spec#66
The code parses the feature id and decides its origin between the new OCI features and old github release based features by verifiying a manifest is available and reachable for said feature.
The main TODO is implementing authentication support for the various operating system keychains and obtain the docker credentials.