Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCI push #99

Merged
merged 35 commits into from
Aug 12, 2022
Merged

OCI push #99

merged 35 commits into from
Aug 12, 2022

Conversation

joshspicer
Copy link
Member

@joshspicer joshspicer commented Aug 2, 2022

Builds on #94

Relevant to : devcontainers/spec#66

Implements the relevant parts of the OCI distribution-spec: https://github.com/opencontainers/distribution-spec/blob/main/spec.md

Example of manually triggering pushOCIFeature with --log-level trace. Note that here all the blobs had already been uploaded to the registry previously, so the CLI did not try to republish them. The result can be seen publicly here: https://github.com/users/joshspicer/packages/container/package/mypackages%2Fcolor

image

image

This PR provides the distribution spec implementation. The user-facing portion is being completed separately in PR #97

@joshspicer joshspicer changed the title add push work OCI push Aug 2, 2022
Base automatically changed from oci to main August 3, 2022 14:18
@joshspicer joshspicer marked this pull request as ready for review August 11, 2022 14:46
@joshspicer joshspicer requested a review from a team as a code owner August 11, 2022 14:46
@joshspicer joshspicer requested a review from chrmarti August 11, 2022 14:48
@@ -7,262 +7,289 @@ import { FeatureSet } from './containerFeaturesConfiguration';

Copy link
Member Author

@joshspicer joshspicer Aug 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also converted this file to tabs. I suggest enabling 'hide whitespace changes' in the GitHub PR UI.

Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joshspicer joshspicer merged commit c97190e into main Aug 12, 2022
@joshspicer joshspicer deleted the oci-with-push branch August 12, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants