Add Shift+D command to delete numeric namespace bindings

[placintaalexandru]

Addresses #2104

[derailed]

@placintaalexandru Thank you for this update Alexandru!!
I am kind of on the fence with this one...
I think it might be best to enhance the ns view to offer a new col aka favorite and leverage a toggle to opt in/out to make up the favs ns list.
That said, since auto favs ns is still in play, that list will keep changing and user would have to manually curate it. Which feels like a dud.

[placintaalexandru]

@placintaalexandru Thank you for this update Alexandru!! I am kind of on the fence with this one... I think it might be best to enhance the ns view to offer a new col aka favorite and leverage a toggle to opt in/out to make up the favs ns list. That said, since auto favs ns is still in play, that list will keep changing and user would have to manually curate it. Which feels like a dud.

I agree @derailed . I can have a look at enhancing the fav ns thing: by default would be this behaviour that would allow you to delete the numeric bindings, but if the user specifies a flag (e.g., --fav) the fav ns will always be hardoced to the list specified by the user

If you agree, you can close this one and I'll work on what I said above if that is fine

[derailed]

@placintaalexandru Thank you Alexandru!! I think we might be able to manage this without hopefully introducing a new flag?? Perhaps if the user sets her fav ns then the auto tracking ns could either be disabled is the fav ns list is full or just managed the list if there is still space in it??

[placintaalexandru]

I mean, I could stil want a self managed list of 4 namespaces and those 4 to never change @derailed
This is why I was thinking to a flag :\

[derailed]

@placintaalexandru Thank you for this update Alexandru!
I like this feature but it feels a bit heavy to me in its current shape??
Here is a thought. What if we displayed a favorite indicator (❤️) next to the namespace name and add an action something like f Toggle Favorite?
Then users could leverage familiar constructs like multi-select, etc... to manage their fav list?

[placintaalexandru]

@placintaalexandru Thank you for this update Alexandru! I like this feature but it feels a bit heavy to me in its current shape?? Here is a thought. What if we displayed a favorite indicator (❤️) next to the namespace name and add an action something like f Toggle Favorite? Then users could leverage familiar constructs like multi-select, etc... to manage their fav list?

yeah, SGTM. I'll try to work on this one again

[placintaalexandru]

hello @derailed
There is now the possibility to toggle a namespace as favourite and, in case it exists, to toggle it out from favourite. I use behind data.Namespace.AddFavNS and data.Namespace.RmFavNS.

I don't understand 2 things:

1. Is it still required to limit the number of favourite namespaces to 9?
2. How would the user manage the fav list? I did not understand the multi-select part

[derailed]

@placintaalexandru Thank you for the updates and sorry for the delay ;(
The list of fav is constrained by the current key binding aka 0-9.
As for the multi-select while on ns view, I was thinking you can hand pick a few ns and toggle favs to mark or unmark them as favorites??

[placintaalexandru]

Hello @derailed

The PR does exactly that, but I was not sure if it had to do something more: it only allows the user to add a namespace to favorite

[derailed]

@placintaalexandru Thank you! Once the conflict is resolved I think we can merge...

[placintaalexandru]

@derailed, I can't seem to be able to build neither the binary nor the tests, not even on the latest master commit.

The problem seems to be this commit.