Add toggle button for favorite namespaces

internal/config/data/ns.go

@@ -65,7 +65,7 @@ func (n *Namespace) Validate(c client.Connection) {
  for _, ns := range n.Favorites {
  if !c.IsValidNamespace(ns) {
  log.Debug().Msgf("[Namespace] Invalid favorite found '%s' - %t", ns, n.isAllNamespaces())
- n.rmFavNS(ns)
+ n.RmFavNS(ns)
  }
  }
 }
@@ -85,17 +85,18 @@ func (n *Namespace) SetActive(ns string, ks KubeSettings) error {
  n.Active = ns
 
  if ns != "" && !n.LockFavorites {
- n.addFavNS(ns)
+ n.AddFavNS(ns)
  }
 
  return nil
 }
 
 func (n *Namespace) isAllNamespaces() bool {
- return n.Active == client.NamespaceAll || n.Active == ""
+ return client.IsAllNamespaces(n.Active)
 }
 
-func (n *Namespace) addFavNS(ns string) {
+// AddFavNS adds a namespace to the list of favorites namespaces
+func (n *Namespace) AddFavNS(ns string) {
  if InList(n.Favorites, ns) {
  return
  }
@@ -110,11 +111,8 @@ func (n *Namespace) addFavNS(ns string) {
  n.Favorites = nfv
 }
 
-func (n *Namespace) rmFavNS(ns string) {
- if n.LockFavorites {
- return
- }
-
+// RmFavNS removes a namespace from the list of favorites namespaces
+func (n *Namespace) RmFavNS(ns string) {
  victim := -1
  for i, f := range n.Favorites {
  if f == ns {

internal/view/ns.go

@@ -5,14 +5,16 @@ package view
 
 import (
  "github.com/derailed/k9s/internal/client"
+ "github.com/derailed/k9s/internal/config/data"
  "github.com/derailed/k9s/internal/model1"
  "github.com/derailed/k9s/internal/ui"
  "github.com/derailed/tcell/v2"
 )
 
 const (
- favNSIndicator = "+"
- defaultNSIndicator = "(*)"
+ favNSIndicator = " ❤️ "
+ defaultNSIndicator = "(*)"
+ deleteNumericBindingsKey = "delete-ns-numeric-bindings"
 )
 
 // Namespace represents a namespace viewer.
@@ -36,6 +38,8 @@ func (n *Namespace) bindKeys(aa *ui.KeyActions) {
  aa.Bulk(ui.KeyMap{
  ui.KeyU: ui.NewKeyAction("Use", n.useNsCmd, true),
  ui.KeyShiftS: ui.NewKeyAction("Sort Status", n.GetTable().SortColCmd(statusCol, true), false),
+ // ui.KeyShiftD: ui.NewKeyAction("Delete Binding", n.deleteNamespaceKeyBindings, true),
+ ui.KeyF: ui.NewKeyAction("Toggle Favorite", n.toggleFavorite, true),
  })
 }
 
@@ -103,3 +107,25 @@ func (n *Namespace) decorate(td *model1.TableData) {
  return true
  })
 }
+
+func (n *Namespace) toggleFavorite(evt *tcell.EventKey) *tcell.EventKey {
+ _, ns := client.Namespaced(n.GetTable().GetSelectedItem())
+
+ if ns == "" {
+ return nil
+ }
+
+ ctx, err := n.App().Config.K9s.ActiveContext()
+
+ if err != nil {
+ return evt
+ }
+
+ if data.InList(n.App().Config.FavNamespaces(), ns) {
+ ctx.Namespace.RmFavNS(ns)
+ } else {
+ ctx.Namespace.AddFavNS(ns)
+ }
+
+ return nil
+}

internal/view/ns_test.go

@@ -16,5 +16,5 @@ func TestNSCleanser(t *testing.T) {
 
  assert.Nil(t, ns.Init(makeCtx()))
  assert.Equal(t, "Namespaces", ns.Name())
- assert.Equal(t, 7, len(ns.Hints()))
+ assert.Equal(t, 8, len(ns.Hints()))
 }