feat: Depcrate SourceMapGetter
, move methods to ModuleLoader
#823
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit deprecates
SourceMapGetter
trait,JsRuntime::source_map_getter
option and updates
ModuleLoader
trait to have the same methods asSourceMapGetter
.In real usage it's always implementor of
ModuleLoader
that also implementsSourceMapGetter
. It makes little sense to keep these two trait separate.This will open up doors for native source map support that is being
developed in #819.
SourceMapGetter
is scheduled to be removed in 0.297.0.