Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SourceMapper correctly uses ModuleLoader to get source lines #827

Merged
merged 6 commits into from
Jul 16, 2024

Conversation

bartlomieju
Copy link
Member

Fixes SourceMapper API that was changed in #823.

Now the source lines are correctly mapped even if deprecated SourceMapGetter API is not
used.

I need to add some tests too.

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 74.46809% with 24 lines in your changes missing coverage. Please review.

Project coverage is 81.61%. Comparing base (0c7f83e) to head (490cc97).
Report is 63 commits behind head on main.

Files Patch % Lines
core/source_map.rs 72.41% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #827      +/-   ##
==========================================
+ Coverage   81.43%   81.61%   +0.18%     
==========================================
  Files          97       98       +1     
  Lines       23877    24383     +506     
==========================================
+ Hits        19445    19901     +456     
- Misses       4432     4482      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bartlomieju bartlomieju enabled auto-merge (squash) July 16, 2024 22:37
@bartlomieju bartlomieju merged commit 043b147 into denoland:main Jul 16, 2024
18 checks passed
@bartlomieju bartlomieju deleted the fix_source_maps branch July 16, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants