feat: Implement UCCommitter::publish
#1626
Open
+424
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 17, 2026
scottsand-db
commented
Jan 17, 2026
scottsand-db
changed the title
UCCommitter::publish
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1626 +/- ##
==========================================
+ Coverage 84.16% 84.22% +0.06%
==========================================
Files 123 124 +1
Lines 34148 34364 +216
Branches 34148 34364 +216
==========================================
+ Hits 28739 28943 +204
- Misses 4020 4031 +11
- Partials 1389 1390 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scottsand-db
force-pushed
the
stack/committer_publish_3
branch
from
86c6764 to
4675bbc
Compare
scottsand-db
force-pushed
the
stack/committer_publish_3
branch
from
4675bbc to
3dd3444
Compare
scottsand-db
force-pushed
the
stack/committer_publish_3
branch
2 times, most recently
from
22da31d to
97ea4d6
Compare
Add new types and methods to support publishing catalog commits to the Delta log: - CatalogCommit: Represents a ratified catalog commit that needs to be published - PublishMetadata: Bundles the information needed for publishing (snapshot version and list of catalog commits to publish) - PublishResult: Enum indicating success or not-applicable for non-catalog committers - Committer::is_catalog_committer(): Returns whether this is a catalog committer - Committer::publish(): Publishes catalog commits to the Delta log Update FileSystemCommitter and UCCommitter to implement the new trait methods. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
scottsand-db
force-pushed
the
stack/committer_publish_3
branch
from
97ea4d6 to
c58781b
Compare
scottsand-db
force-pushed
the
stack/committer_publish_3
branch
from
c58781b to
c910126
Compare
scottsand-db
requested review from
OussamaSaoudi
and removed request for
OussamaSaoudi
github-actions
bot
added
the
breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
What changes are proposed in this pull request?
This PR implements the
UCCommitter::publishAPI. It's pretty simple. We us the Engine StorageHandler trait to atomically copy files from staged location published location.How was this change tested?
New UT.