Skip to content

Conversation

@scottsand-db
Copy link
Collaborator

@scottsand-db scottsand-db commented Jan 16, 2026

🥞 Stacked PR

Use this link to review incremental changes.


What changes are proposed in this pull request?

Move the committer module from a single file into a directory structure:

  • mod.rs: Committer trait and re-exports
  • metadata.rs: CommitMetadata, CommitResponse
  • filesystem.rs: FileSystemCommitter

No functional changes, just reorganization for better maintainability.

How was this change tested?

Existing UTs.

@github-actions github-actions bot added the breaking-change Change that require a major version bump label Jan 16, 2026
@scottsand-db scottsand-db force-pushed the stack/committer_publish_1 branch from fd918b7 to 3032a11 Compare January 17, 2026 02:44
@scottsand-db scottsand-db changed the title add CatalogCommit, PublishMetadata, and Committer::publish() APIs refactor: Split committer.rs into multiple files Jan 17, 2026
@codecov
Copy link

codecov bot commented Jan 17, 2026

Codecov Report

❌ Patch coverage is 93.84615% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.16%. Comparing base (9868366) to head (03b2e5c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kernel/src/committer/commit_types.rs 91.93% 5 Missing ⚠️
kernel/src/committer/filesystem.rs 95.58% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1622   +/-   ##
=======================================
  Coverage   84.16%   84.16%           
=======================================
  Files         122      123    +1     
  Lines       34148    34148           
  Branches    34148    34148           
=======================================
  Hits        28739    28739           
  Misses       4020     4020           
  Partials     1389     1389           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scottsand-db scottsand-db force-pushed the stack/committer_publish_1 branch from 3032a11 to 9ba9e5b Compare January 17, 2026 19:35
@github-actions github-actions bot removed the breaking-change Change that require a major version bump label Jan 17, 2026
scottsand-db and others added 3 commits January 21, 2026 16:49
Move the committer module from a single file into a directory structure:
- mod.rs: Committer trait and re-exports
- metadata.rs: CommitMetadata, CommitResponse
- filesystem.rs: FileSystemCommitter

No functional changes, just reorganization for better maintainability.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@scottsand-db scottsand-db force-pushed the stack/committer_publish_1 branch from 4a2c4af to 03b2e5c Compare January 21, 2026 16:49
@scottsand-db scottsand-db merged commit eb3d36c into delta-io:main Jan 21, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants