Skip to content

[controller] Refactor code on linter issues and test improvements. #9

[controller] Refactor code on linter issues and test improvements.

[controller] Refactor code on linter issues and test improvements. #9

Triggered via pull request August 6, 2024 09:16
Status Failure
Total duration 55s
Artifacts

go_lint.yaml

on: pull_request
Go linter for images
46s
Go linter for images
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 3 warnings
Go linter for images
Error return value of `cl.Delete` is not checked (errcheck)
Go linter for images
appendAssign: append result not assigned to the same slice (gocritic)
Go linter for images
captLocal: `VGName' should not be capitalized (gocritic)
Go linter for images
captLocal: `VGName' should not be capitalized (gocritic)
Go linter for images
commentFormatting: put a space between `//` and comment text (gocritic)
Go linter for images
elseif: can replace 'else {if cond {}}' with 'else if cond {}' (gocritic)
Go linter for images
assignOp: replace `factor = factor / 100` with `factor /= 100` (gocritic)
Go linter for images
commentFormatting: put a space between `//` and comment text (gocritic)
Go linter for images
elseif: can replace 'else {if cond {}}' with 'else if cond {}' (gocritic)
Go linter for images
captLocal: `VGName' should not be capitalized (gocritic)
Go linter for images
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Go linter for images
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Go linter for images
Restore cache failed: Dependencies file is not found in /home/ubuntu/actions-runner-1/_work/sds-node-configurator/sds-node-configurator. Supported file pattern: go.sum