[controller] Refactor code on linter issues and test improvements. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorKram
force-pushed
the
v-kramarenko-fixes-linter-suggestions
branch
14 times, most recently
from
3b6d4cd to
250012d
Compare
ViktorKram
force-pushed
the
v-kramarenko-fixes-linter-suggestions
branch
from
250012d to
19aeb2e
Compare
duckhawk
approved these changes
Aug 9, 2024
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
ViktorKram
force-pushed
the
v-kramarenko-fixes-linter-suggestions
branch
from
e44fde5 to
ee0da64
Compare
AleksZimin
approved these changes
Aug 16, 2024
ViktorKram
added a commit
that referenced
this pull request
Sep 17, 2024
Signed-off-by: Viktor Kramarenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring on linter issues and test improvements.
Why do we need it, and what problem does it solve?
More accurate and test-coverage code.
What is the expected result?
Linters do not fail and tests run successfully.
Checklist