Introduces generic defillama scrapper #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agallardol
requested changes
Sep 11, 2024
There was a problem hiding this comment.
@daniel-baez is this tool replacing the existing one about defillama? If that's the case maybe we can just remove the old one? :(
| @@ -237,6 +247,16 @@ lazy_static! { | |||
| .unwrap(), | |||
| )), | |||
| ); | |||
| m.insert( | |||
There was a problem hiding this comment.
Not sure but it seems to be added twice
There was a problem hiding this comment.
right, let me remove it
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@shinkai_protocol/source", | |||
| "version": "0.7.13", | |||
| "version": "0.7.12", | |||
There was a problem hiding this comment.
Why we are "downgrading" the package version?
There was a problem hiding this comment.
m... maybe I pressed x by mistake, let me fix
yes, it can make the same results |
daniel-baez
had a problem deploying
to
development
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
This change introduces directory
apps/shinkai-tool-defillama-tvl-rankingsa simple function taking up to two parameters:The first parameter is named
categoryNameand it's required, this must be one of the names seen under this tableThe second optional parameter is named
networkName, and it must be one of: 'Ethereum', 'Solana', 'Arbitrum', 'Base', 'Cardano', 'Near', 'BSC', 'Sui'Using these two inputs the tool gets the right page from defillama.com returning a csv version of the main table found in it, optionally narrowing down by network name