Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Restore GitLabDSL.api to be GitLabAPI instance #1354

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Feb 7, 2023

Revert "Ensures that the Gitlab API is exposed properly through the dts"

This reverts commit e8d2052.

The breakage introduced between 10.6.5 and 10.6.6 patch version update

Refs:

@glensc glensc self-assigned this Feb 7, 2023
@glensc glensc changed the title Restore GitLabDSL.api to be GitLabAPI instance Fix: Restore GitLabDSL.api to be GitLabAPI instance Feb 7, 2023
@glensc
Copy link
Contributor Author

glensc commented Feb 15, 2023

I think there aren't many gitlab users that has gone un-noticed that long. at least the write methods.

I do use gitlab, not so far did not need to use write functions, just used danger.gitlab json structures

Revert "Ensures that the Gitlab API is exposed properly through the dts"

This reverts commit e8d2052.

The breakage is between 10.6.5 and 10.6.6 version
@glensc
Copy link
Contributor Author

glensc commented Mar 1, 2023

@orta who can give insights and directions on how to the problem? only you?

@orta
Copy link
Member

orta commented Mar 2, 2023

Yep, I do OSS in my increasingly little spare time and so mainly only have time for well formed non-draft PRs

@glensc
Copy link
Contributor Author

glensc commented Jul 30, 2023

hmm. I can no longer update this branch

ERROR: Permission to danger/danger-js.git denied to glensc.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants