-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Expose updateMergeRequestInfo for gitlab api #1391
base: main
Are you sure you want to change the base?
Conversation
The CI error is not from changes of this PR:
|
actually, I ran such code in my danger plugin: await gitlab.api.MergeRequests.edit(mr.project_id, mr.iid, { assigneeId: mr.author.id }) and I'm getting 403, what's with that?
EDIT: I think my token has no write accesss |
@@ -290,6 +290,7 @@ export const gitlabJSONToGitLabDSL = (gl: GitLabDSL, api: GitLabAPI): GitLabDSL | |||
fileContents: api.getFileContents, | |||
addLabels: api.addLabels, | |||
removeLabels: api.removeLabels, | |||
updateMergeRequestInfo: api.updateMergeRequestInfo, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the method be added to utils or top level (aside api: xxx
)?
I don't think we should do this, as this fn is just an alias to |
The wrapped methods add debug calls. it would be useful to see debug logs when troubleshooting. But this all started because incompatible api change: |
I'd imagine there would be similar debugging env vars on the gitlab API instance too - yeah, |
Similarly to #1353, expose
updateMergeRequestInfo
method to be able to edit merge requests from danger code.