Remove lincbrain CLI installation due to dandi CLI handling different APIs #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note this shouldn't be merged and is in draft mode until dandi/dandi-cli#1519 is merged Cc @kabilar |
14 tasks
kabilar
reviewed
Nov 18, 2024
There was a problem hiding this comment.
Thanks Aaron. Perhaps we should also update the managed-jupyterhub file?
|
I think we are ok to merge this PR. In theory we could redeploy dandihub at anytime, but to be cautious I plan to wait to until #207 is addressed and tested on a staging hub. |
kabilar
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Thank you, Aaron and Austin. Since dandi/dandi-cli#1527 is merged, I am proceeding here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies JupyterHub installation due to changes in dandi/dandi-cli#1519
Relates to
dandi/dandi-cli#1517 (comment) and dandi/dandi-cli#1517
cc @kabilar