-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
download: more consistent and exhaustive logging, new DANDI_DEVEL_AGGRESSIVE_RETRY
mode, respect (?) Retry-After
#1509
Commits on Oct 24, 2024
-
Log download directory path and also either we are entering __exit__ …
…with or without exception etc
Configuration menu - View commit details
-
Copy full SHA for 1286878 - Browse repository at this point
Copy the full SHA 1286878View commit details -
Fix typing check - move assert before use of fp.tell() + shorten the …
…message while at it
Configuration menu - View commit details
-
Copy full SHA for 79f0f48 - Browse repository at this point
Copy the full SHA 79f0f48View commit details -
Add unit-testing for DownloadDirectory to ensure expected operation
Also shortened the log line to not include traceback
Configuration menu - View commit details
-
Copy full SHA for d043359 - Browse repository at this point
Copy the full SHA d043359View commit details -
Add a check that DownloadDirectory moves the file instead of copying …
…(via inode matching)
Configuration menu - View commit details
-
Copy full SHA for 15fde44 - Browse repository at this point
Copy the full SHA 15fde44View commit details -
Move helper function to module level so it could be pickled
not sure why was not failing for me locally but fails on CI
Configuration menu - View commit details
-
Copy full SHA for f436b0c - Browse repository at this point
Copy the full SHA f436b0cView commit details -
Add handling of PermissionError on Windows for an existing directory
That is my guess for what is happening in ________________________ test_DownloadDirectory_basic _________________________ dandi\tests\test_download.py:1048: in test_DownloadDirectory_basic with DownloadDirectory(tmp_path, digests={}) as dl: dandi\download.py:889: in __exit__ self.writefile.replace(self.filepath) C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\pathlib.py:1247: in replace self._accessor.replace(self, target) E PermissionError: [WinError 5] Access is denied: 'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-runneradmin\\pytest-0\\test_DownloadDirectory_basic0.dandidownload\\file' -> 'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-runneradmin\\pytest-0\\test_DownloadDirectory_basic0'
Configuration menu - View commit details
-
Copy full SHA for f7fadeb - Browse repository at this point
Copy the full SHA f7fadebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 028060e - Browse repository at this point
Copy the full SHA 028060eView commit details -
Very unlikely but it could be that directory already existed but without checksum file for some reason.
Configuration menu - View commit details
-
Copy full SHA for d3ce763 - Browse repository at this point
Copy the full SHA d3ce763View commit details -
Configuration menu - View commit details
-
Copy full SHA for ddcab48 - Browse repository at this point
Copy the full SHA ddcab48View commit details -
RF+ENH: also report requests and urllib3 versions, do not prefix with v
no v prefix since is not providing any information on top; sorting for deterministic order
Configuration menu - View commit details
-
Copy full SHA for fb2e782 - Browse repository at this point
Copy the full SHA fb2e782View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a78454 - Browse repository at this point
Copy the full SHA 5a78454View commit details -
Demand urllib3 to be no less than 2.0.0 in which enforce_content_leng…
…th was set to default to True
Configuration menu - View commit details
-
Copy full SHA for a4db7bc - Browse repository at this point
Copy the full SHA a4db7bcView commit details -
ENH: respect/log separately Retry-After + support DANDI_DEVEL_AGGRESS…
…IVE_RETRY mode This is all to address that odd case with 000026 where connection keeps interrupting. Unclear why so adding more specific cases handling and allowing for such an aggressive retrying where we would proceed as long as we are getting something (but sleep would also increase)
Configuration menu - View commit details
-
Copy full SHA for f52a363 - Browse repository at this point
Copy the full SHA f52a363View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9226f0 - Browse repository at this point
Copy the full SHA a9226f0View commit details
Commits on Nov 12, 2024
-
State minimal version of duecredit to be 0.6.0
pip fails to deal with metadata of 0.5.0 due to missing __version__
Configuration menu - View commit details
-
Copy full SHA for ad069c8 - Browse repository at this point
Copy the full SHA ad069c8View commit details
Commits on Nov 14, 2024
-
Use vcrpy only for python >= 3.10
See more info at - urllib3/urllib3#3017 - kevin1024/vcrpy#688
Configuration menu - View commit details
-
Copy full SHA for 08450ed - Browse repository at this point
Copy the full SHA 08450edView commit details -
fix(workaround,test): completely skip running test_DownloadDirectory_…
…basic on windows Somehow that causes "indigestion" to pytest process later in its life cycle
Configuration menu - View commit details
-
Copy full SHA for 7f97394 - Browse repository at this point
Copy the full SHA 7f97394View commit details