download: more consistent and exhaustive logging, new DANDI_DEVEL_AGGRESSIVE_RETRY mode, respect (?) Retry-After
#1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1509 +/- ##
==========================================
- Coverage 88.58% 88.51% -0.08%
==========================================
Files 78 78
Lines 10589 10689 +100
==========================================
+ Hits 9380 9461 +81
- Misses 1209 1228 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…with or without exception etc
…message while at it
Also shortened the log line to not include traceback
…(via inode matching)
not sure why was not failing for me locally but fails on CI
That is my guess for what is happening in
________________________ test_DownloadDirectory_basic _________________________
dandi\tests\test_download.py:1048: in test_DownloadDirectory_basic
with DownloadDirectory(tmp_path, digests={}) as dl:
dandi\download.py:889: in __exit__
self.writefile.replace(self.filepath)
C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\pathlib.py:1247: in replace
self._accessor.replace(self, target)
E PermissionError: [WinError 5] Access is denied: 'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-runneradmin\\pytest-0\\test_DownloadDirectory_basic0.dandidownload\\file' -> 'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-runneradmin\\pytest-0\\test_DownloadDirectory_basic0'
Very unlikely but it could be that directory already existed but without checksum file for some reason.
no v prefix since is not providing any information on top; sorting for deterministic order
…th was set to default to True
…IVE_RETRY mode This is all to address that odd case with 000026 where connection keeps interrupting. Unclear why so adding more specific cases handling and allowing for such an aggressive retrying where we would proceed as long as we are getting something (but sleep would also increase)
|
FTR: rebased/force-pushed to get a fresh run of tests after recent changes and drop of 3.8 support. |
pip fails to deal with metadata of 0.5.0 due to missing __version__
See more info at - urllib3/urllib3#3017 - kevin1024/vcrpy#688
4 tasks
…basic on windows Somehow that causes "indigestion" to pytest process later in its life cycle
|
ok
overall -- we are "ready" here as testing concerned. |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was originally developed as part of the PR but derailed into fixing/robustifying download functionality. So sits on top of
TODOs
possibly fold in herefixup for download to do full file checksumming if download was resumed: Add checksumming of the full download in case of retries #1528