-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: suppress EGL Driver message in electron 32 #30663
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
# @cypress/angular-signals | ||
|
||
Mount Angular components in the open source [Cypress.io](https://www.cypress.io/) test runner. This package is an extension of `@cypress/angular`, but with [signals](https://angular.dev/guide/signals) support. | ||
|
||
> **Note:** This package is bundled with the `cypress` package and should not need to be installed separately. See the [Angular Component Testing Docs](https://docs.cypress.io/guides/component-testing/angular/overview) for mounting Angular components. Installing and importing `mount` from `@cypress/angular-signals` should only be done for advanced use-cases. | ||
|
||
## Development | ||
|
||
Run `yarn build` to compile and sync packages to the `cypress` cli package. | ||
|
||
## [Changelog](./CHANGELOG.md) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
{ | ||
"name": "@cypress/angular-signals", | ||
"version": "0.0.0-development", | ||
"description": "Test Angular Components using Signals with Cypress", | ||
"main": "dist/index.js", | ||
"scripts": { | ||
"prebuild": "rimraf dist", | ||
"build": "rollup -c rollup.config.mjs", | ||
"postbuild": "node ../../scripts/sync-exported-npm-with-cli.js", | ||
"check-ts": "tsc --noEmit", | ||
"dev": "rollup -c rollup.config.mjs -w", | ||
"lint": "eslint --ext .js,.ts,.json, ." | ||
}, | ||
"dependencies": {}, | ||
"devDependencies": { | ||
"@angular/common": "^17.2.0", | ||
"@angular/core": "^17.2.0", | ||
"@angular/platform-browser-dynamic": "^17.2.0", | ||
"@cypress/mount-utils": "0.0.0-development", | ||
"typescript": "~5.4.5", | ||
"zone.js": "~0.14.6" | ||
}, | ||
"peerDependencies": { | ||
"@angular/common": ">=17.2", | ||
"@angular/core": ">=17.2", | ||
"@angular/platform-browser-dynamic": ">=17.2", | ||
"rxjs": ">=7.5.0", | ||
"zone.js": ">=0.13.0" | ||
}, | ||
"files": [ | ||
"dist" | ||
], | ||
"types": "dist/index.d.ts", | ||
"license": "MIT", | ||
"repository": { | ||
"type": "git", | ||
"url": "https://github.com/cypress-io/cypress.git" | ||
}, | ||
"homepage": "https://github.com/cypress-io/cypress/blob/develop/npm/angular-signals/#readme", | ||
"bugs": "https://github.com/cypress-io/cypress/issues/new?assignees=&labels=npm%3A%20%40cypress%2Fangular&template=1-bug-report.md&title=", | ||
"keywords": [ | ||
"angular", | ||
"cypress", | ||
"cypress-io", | ||
"test", | ||
"testing" | ||
], | ||
"contributors": [ | ||
{ | ||
"name": "Bill Glesias", | ||
"social": "@atofstryker" | ||
} | ||
], | ||
"module": "dist/index.js", | ||
"publishConfig": { | ||
"access": "public" | ||
}, | ||
"nx": { | ||
"targets": { | ||
"build": { | ||
"outputs": [ | ||
"{workspaceRoot}/cli/angular-signals" | ||
] | ||
} | ||
} | ||
}, | ||
"standard": { | ||
"globals": [ | ||
"Cypress", | ||
"cy", | ||
"expect" | ||
] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -76,7 +76,15 @@ const isContainerVulkanStack = /^\s*at (CheckVkSuccessImpl|CreateVkInstance|Init | |
*/ | ||
const isDebugScenario4 = /^\[[^\]]+debug_utils\.cc[^\]]+\] Hit debug scenario: 4/ | ||
|
||
const GARBAGE_WARNINGS = [isXlibOrLibudevRe, isHighSierraWarningRe, isRenderWorkerRe, isDbusWarning, isCertVerifyProcBuiltin, isHostVulkanDriverWarning, isContainerVulkanDriverWarning, isContainerVulkanStack, isDebugScenario4] | ||
/** | ||
* In Electron 32.0.0 a new EGL driver message started appearing when running on Linux. This is a benign message. | ||
* https://github.com/electron/electron/issues/43415 | ||
* Sample: | ||
* [78887:1023/114920.074882:ERROR:gl_display.cc(14)] EGL Driver message (Error) eglQueryDeviceAttribEXT: Bad attribute. | ||
*/ | ||
const isEGLDriverMessage = /^\[[^\]]+gl_display\.cc[^\]]+\] EGL Driver message \(Error\) eglQueryDeviceAttribEXT: Bad attribute\./ | ||
|
||
const GARBAGE_WARNINGS = [isXlibOrLibudevRe, isHighSierraWarningRe, isRenderWorkerRe, isDbusWarning, isCertVerifyProcBuiltin, isHostVulkanDriverWarning, isContainerVulkanDriverWarning, isContainerVulkanStack, isDebugScenario4, isEGLDriverMessage] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. probably after this merges we test the binary on intel mac? |
||
|
||
const isGarbageLineWarning = (str) => { | ||
return _.some(GARBAGE_WARNINGS, (re) => { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
# @cypress/vue2 | ||
|
||
Mount Vue 2 components in the open source [Cypress.io](https://www.cypress.io/) test runner | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here with the checked in files |
||
|
||
> **Note:** This package is bundled with the `cypress` package and should not need to be installed separately. See the [Vue Component Testing Docs](https://docs.cypress.io/guides/component-testing/vue/overview) for mounting Vue components. Installing and importing `mount` from `@cypress/vue2` should only be done for advanced use-cases. | ||
|
||
## [Changelog](./CHANGELOG.md) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
{ | ||
"name": "@cypress/vue2", | ||
"version": "0.0.0-development", | ||
"description": "Browser-based Component Testing for Vue.js@2 with Cypress.io ✌️🌲", | ||
"main": "dist/cypress-vue2.cjs.js", | ||
"scripts": { | ||
"build": "rimraf dist && yarn rollup -c rollup.config.mjs", | ||
"postbuild": "node ../../scripts/sync-exported-npm-with-cli.js", | ||
"check-ts": "tsc --noEmit", | ||
"lint": "eslint --ext .js,.jsx,.ts,.tsx,.json,.vue .", | ||
"test": "echo \"Tests for @cypress/vue2 are run from system-tests\"", | ||
"test-ci": "node ../../scripts/run-ct-examples.js --examplesList=./examples.env", | ||
"watch": "yarn build --watch --watch.exclude ./dist/**/*" | ||
}, | ||
"devDependencies": { | ||
"@cypress/mount-utils": "0.0.0-development", | ||
"@rollup/plugin-json": "^4.1.0", | ||
"@rollup/plugin-replace": "^2.3.1", | ||
"@vue/test-utils": "^1.3.1", | ||
"tslib": "^2.1.0", | ||
"typescript": "~5.4.5", | ||
"vue": "2.7.16" | ||
}, | ||
"peerDependencies": { | ||
"cypress": ">=4.5.0", | ||
"vue": "^2.0.0" | ||
}, | ||
"files": [ | ||
"dist/**/*", | ||
"src/**/*.js" | ||
], | ||
"engines": { | ||
"node": ">=8" | ||
}, | ||
"types": "dist/index.d.ts", | ||
"license": "MIT", | ||
"repository": { | ||
"type": "git", | ||
"url": "https://github.com/cypress-io/cypress.git" | ||
}, | ||
"homepage": "https://github.com/cypress-io/cypress/blob/develop/npm/vue/#readme", | ||
"bugs": "https://github.com/cypress-io/cypress/issues/new?assignees=&labels=npm%3A%20%40cypress%2Fvue&template=1-bug-report.md&title=", | ||
"keywords": [ | ||
"cypress", | ||
"vue" | ||
], | ||
"unpkg": "dist/cypress-vue2.browser.js", | ||
"module": "dist/cypress-vue2.esm-bundler.js", | ||
"publishConfig": { | ||
"access": "public" | ||
}, | ||
"nx": { | ||
"targets": { | ||
"build": { | ||
"outputs": [ | ||
"{workspaceRoot}/cli/vue2", | ||
"{projectRoot}/dist" | ||
] | ||
} | ||
}, | ||
"implicitDependencies": [ | ||
"!cypress" | ||
] | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like these files got checked in since the harness is now deleted on 14. Might need to do a
git reset HEAD~
and agit clean -fd
or something and recommit?