chore: suppress EGL Driver message in electron 32 #30663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AtofStryker
requested changes
Nov 21, 2024
cli/angular-signals/README.md
Outdated
| # @cypress/angular-signals | ||
|
|
||
| Mount Angular components in the open source [Cypress.io](https://www.cypress.io/) test runner. This package is an extension of `@cypress/angular`, but with [signals](https://angular.dev/guide/signals) support. | ||
|
|
There was a problem hiding this comment.
looks like these files got checked in since the harness is now deleted on 14. Might need to do a git reset HEAD~ and a git clean -fd or something and recommit?
cli/vue2/README.md
Outdated
| @@ -0,0 +1,7 @@ | |||
| # @cypress/vue2 | |||
|
|
|||
| Mount Vue 2 components in the open source [Cypress.io](https://www.cypress.io/) test runner | |||
There was a problem hiding this comment.
same here with the checked in files
| */ | ||
| const isEGLDriverMessage = /^\[[^\]]+gl_display\.cc[^\]]+\] EGL Driver message \(Error\) eglQueryDeviceAttribEXT: Bad attribute\./ | ||
|
|
||
| const GARBAGE_WARNINGS = [isXlibOrLibudevRe, isHighSierraWarningRe, isRenderWorkerRe, isDbusWarning, isCertVerifyProcBuiltin, isHostVulkanDriverWarning, isContainerVulkanDriverWarning, isContainerVulkanStack, isDebugScenario4, isEGLDriverMessage] |
There was a problem hiding this comment.
probably after this merges we test the binary on intel mac?
AtofStryker
approved these changes
Nov 21, 2024
cypress
|
||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ryanm/fix/filter-message
|
| Run status |
|
| Run duration | 17m 22s |
| Commit |
|
| Committer | Ryan Manuel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
73
|
Skipped
|
0
|
Passing
|
5591
|
| View all changes introduced in this branch ↗︎ | |
Warning
No Report: Something went wrong and we could not generate a report for the Application Quality products.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This suppresses a message that started showing up on the release 14.0.0 branch with the electron upgrade. Calling it a chore since it is not fixing anything that has been released yet.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?