Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup cross-origin logs between tests #28465

Closed
wants to merge 8 commits into from
Closed

fix: cleanup cross-origin logs between tests #28465

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fe2b744
run ci
emilyrohrbough Dec 5, 2023
035efd4
add changelog
emilyrohrbough Dec 5, 2023
fd343db
Update packages/app/src/runner/event-manager.ts
emilyrohrbough Dec 5, 2023
d6b225e
Update cli/CHANGELOG.md
emilyrohrbough Dec 6, 2023
1ef9c4a
this is already tracked by queue & changelog update per jennifers fee…
emilyrohrbough Dec 6, 2023
2a1f1cb
Merge branch 'em/clean-origin-logs-between-tests' of https://github.c…
emilyrohrbough Dec 6, 2023
3cb767d
Update cli/CHANGELOG.md
emilyrohrbough Dec 7, 2023
ac15ac6
Merge branch 'develop' into em/clean-origin-logs-between-tests
jennifer-shehane Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cli/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
<!-- See the ../guides/writing-the-cypress-changelog.md for details on writing the changelog. -->
## 13.6.1

_Released 12/19/2023 (PENDING)_

**Bugfixes:**

- Release cy.origin logs between tests. Fixed in [#28465](https://github.com/cypress-io/cypress/issues/28465).
emilyrohrbough marked this conversation as resolved.
Show resolved Hide resolved

## 13.6.1

_Released 12/5/2023_

**Bugfixes:**
Expand Down
2 changes: 2 additions & 0 deletions packages/app/src/runner/event-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,6 +631,8 @@ export class EventManager {
})
}

// remove cross-origin log references from previous test
crossOriginLogs = {}
Cypress.primaryOriginCommunicator.toAllSpecBridges('test:before:run:async', ...args)
})

Expand Down
Loading