Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cleanup cross-origin logs between tests #28465

Closed
wants to merge 8 commits into from
Closed

fix: cleanup cross-origin logs between tests #28465

wants to merge 8 commits into from

Conversation

emilyrohrbough
Copy link
Member

Clean-up cross-origin logs between tests.

PR Tasks

@cypress Cypress
Copy link

cypress bot commented Dec 5, 2023 •
edited
Loading

6 flaky tests on run #52675 ↗︎

0 554 6 0 Flakiness 6

Details:

Merge branch 'em/clean-origin-logs-between-tests' of https://github.com/cypress-...
Project: cypress Commit: 2a1f1cb19b
Status: Passed Duration: 13:12 💡
Started: Dec 6, 2023 11:40 AM Ended: Dec 6, 2023 11:53 AM
Flakiness  runs.cy.ts • 3 flaky tests • app-e2e

View Output

Test Artifacts
App: Runs > Runs - Create Project > when a project is created, injects new projectId into the config file, and sends expected UTM params Test Replay Screenshots
App: Runs > Runs - Cannot Find Project > opens Connect Project modal after clicking Reconnect Project button Test Replay Screenshots
... > displays a list of recorded runs if a run has been recorded Test Replay Screenshots
Flakiness  debug.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
App - Debug Page > shows running and updating build Test Replay Screenshots
Flakiness  cypress-in-cypress.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
Cypress in Cypress > scales the AUT correctly in component Test Replay Screenshots
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Test Replay Screenshots

Review all test suite changes for PR #28465 ↗︎

emilyrohrbough
emilyrohrbough commented Dec 6, 2023
View reviewed changes
cli/CHANGELOG.md Outdated Show resolved Hide resolved
jennifer-shehane
jennifer-shehane reviewed Dec 6, 2023
View reviewed changes
cli/CHANGELOG.md Outdated Show resolved Hide resolved
@emilyrohrbough
this is already tracked by queue & changelog update per jennifers fee…
1ef9c4a 
…dback
@emilyrohrbough
Merge branch 'em/clean-origin-logs-between-tests' of https://github.c…
2a1f1cb 
…om/cypress-io/cypress into em/clean-origin-logs-between-tests

# Conflicts:
#	cli/CHANGELOG.md
#	packages/app/src/runner/event-manager.ts
emilyrohrbough
emilyrohrbough commented Dec 7, 2023
View reviewed changes
cli/CHANGELOG.md Outdated Show resolved Hide resolved
@emilyrohrbough emilyrohrbough deleted the em/clean-origin-logs-between-tests branch December 28, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennifer-shehane jennifer-shehane jennifer-shehane left review comments

@mschile mschile mschile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilyrohrbough @jennifer-shehane @mschile