Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement burn-in logic #28266

Merged
merged 29 commits into from
Nov 28, 2023

Conversation

MuazOthman
Copy link
Contributor

@MuazOthman MuazOthman commented Nov 7, 2023

Requirements

  • Store the burn-in action state on each mocha runnable instance
  • Refactor the existing experimental retries code
  • Write tests in system-tests/record_spec.js for all the enumerated conditions
  • Rewire how actions are stored on Cypress.__actions

Additional details

Steps to test

How has the user experience changed?

PR Tasks

@MuazOthman MuazOthman changed the title Implement burn-in logic feat: Implement burn-in logic Nov 7, 2023
Copy link

cypress bot commented Nov 7, 2023

33 flaky tests on run #52547 ↗︎

0 28530 1346 0 Flakiness 33

Details:

Address PR feedback
Project: cypress Commit: 84f4ed6db3
Status: Passed Duration: 20:53 💡
Started: Nov 28, 2023 4:14 PM Ended: Nov 28, 2023 4:35 PM
Flakiness  commands/querying/querying.cy.js • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > throws after timing out after a .wait() alias reference Test Replay
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output

Test Artifacts
... > correctly returns currentRetry Test Replay
... > correctly returns currentRetry Test Replay
... > correctly returns currentRetry Test Replay
Flakiness  e2e/origin/snapshots.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
cy.origin - snapshots > e2e log verification > Does not take snapshots of XHR/fetch requests from secondary origin if the wrong origin is visited / origin mismatch, but instead the primary origin (existing behavior) Test Replay
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary
    </td>
  </tr></table>
Flakiness  e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
cy.origin assertions > #consoleProps > .should() and .and()
    </td>
  </tr></table>

The first 5 flaky specs are shown, see all 21 specs in Cypress Cloud.

Review all test suite changes for PR #28266 ↗︎

@MuazOthman MuazOthman marked this pull request as ready for review November 22, 2023 18:19
packages/driver/src/cypress/mocha.ts Outdated Show resolved Hide resolved
packages/driver/src/burnIn/index.ts Outdated Show resolved Hide resolved
system-tests/test/record_spec.js Outdated Show resolved Hide resolved
packages/driver/src/cypress/runner.ts Show resolved Hide resolved
@ryanthemanuel ryanthemanuel merged commit 8f150de into feature/test-burn-in Nov 28, 2023
2 of 3 checks passed
@ryanthemanuel ryanthemanuel deleted the muaz/CYCLOUD-1665-burn-in-logic branch November 28, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants