chore: refactore the mocha patch #28323
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-mann
commented
Nov 22, 2023
|
|
||
| // TODO: refactor this | ||
| // requeue the test if we have retries and haven't satisfied our retry configuration. | ||
| if (retry < test.retries() && testStatusInfo.shouldAttemptsContinue) { |
There was a problem hiding this comment.
@MuazOthman pointing out that this is a bug bc retries may not be on but you could still have burn-in enabled, this isn't a problem in this PR, it'll be a problem in the burnin PR.
1 task
|
This PR has not had any activity in 180 days. If no activity is detected in the next 14 days, this PR will be closed. |
|
This PR has been closed due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
systemTest.it(...)definitionstatsStore.incrementCount(runnable?._cypressTestStatusInfo?.outerStatus || runnable.state!)should be a dynamic getterdetect-flake-and-always-failtodetect-flake-but-always-failAdditional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?