Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Electron (at least) 33.1.0 #30561

Closed
ryanthemanuel opened this issue Nov 6, 2024 · 1 comment
Closed

Upgrade to Electron (at least) 33.1.0 #30561

ryanthemanuel opened this issue Nov 6, 2024 · 1 comment
Assignees
@mschile
Labels
browser: electron Cypress 14 Issues scoped for Cypress 14 pkg/electron This is due to an issue in the packages/electron directory

Comments

@ryanthemanuel
Copy link
Collaborator

What would you like?

We should upgrade Electron to at least v33.1.0. We needed to wait until this was released to ensure we didn't have an extremely large increase in binary size. This was released on v33.1.0

Why is this needed?

No response

Other

No response
@ryanthemanuel ryanthemanuel mentioned this issue Nov 6, 2024
Closed
@mschile mschile self-assigned this Dec 4, 2024
@ryanthemanuel
Copy link
Collaborator Author

This was the branch I started with: https://github.com/cypress-io/cypress/tree/ryanm/chore/electron-33-upgrade

@jennifer-shehane jennifer-shehane added Cypress 14 Issues scoped for Cypress 14 pkg/electron This is due to an issue in the packages/electron directory browser: electron labels Dec 4, 2024
@mschile mschile mentioned this issue Dec 4, 2024
Merged
@mschile mschile closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mschile mschile

Labels
browser: electron Cypress 14 Issues scoped for Cypress 14 pkg/electron This is due to an issue in the packages/electron directory
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jennifer-shehane @mschile @ryanthemanuel