dependency: electron 33 upgrade #30716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ryanm/chore/electron-33-upgrade
|
| Run status |
|
| Run duration | 17m 22s |
| Commit |
|
| Committer | Matthew Schile |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
28
|
Skipped
|
0
|
Passing
|
765
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
66.27%
|
|
|---|---|
|
Untested elements
|
26
|
|
Tested elements
|
55
|
Accessibility
96.2%
|
|
|---|---|
|
Failed rules
|
0 critical
4 serious
1 moderate
0 minor
|
|
Failed elements
|
198
|
mschile
force-pushed
the
ryanm/chore/electron-33-upgrade
branch
from
064a1f5 to
e4d80f0
Compare
ryanthemanuel
approved these changes
Dec 5, 2024
AtofStryker
reviewed
Dec 6, 2024
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This pull request includes several updates to dependencies, configurations, and CI workflows to support the upgrade of Electron and Node.js versions. The most important changes include updating the Electron version, Node.js version, Docker images, and related configurations.
Dependency and Version Updates:
20.18.0to20.18.1in various files, including.node-version,package.json, and issue templates. [1] [2] [3] [4] [5]32.2.0to33.2.1inpackage.json. [1] [2]20.18.1and updated browsers in.circleci/workflows.ymlanddocker-compose.yml. [1] [2] [3] [4] [5]Configuration Updates:
better-sqlite3prebuild command to target Electron33.2.1in.circleci/workflows.yml.normalizeStdoutfunction to handle new height dimension offsets for Firefox version 133 insystem-tests/lib/normalizeStdout.ts. This change is not related to the electron upgrade but since I updated the Firefox version in the docker images, the screenshot dimensions in the system-tests changed. I've logged screenshot height dimensions changed in firefox 133 #30721 to investigate further.Steps to test
How has the user experience changed?
n/a
PR Tasks
cypress-documentation?type definitions?