Expose composite ready state in function response #218
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexei Tenitski <[email protected]>
tenitski
force-pushed
the
tenitski/composite-ready
branch
from
06d1266 to
634ed8a
Compare
tenitski
commented
Jul 23, 2025
| @@ -39,6 +39,8 @@ type ConnectionDetails map[string][]byte | |||
| type Composite struct { | |||
| Resource *composite.Unstructured | |||
| ConnectionDetails ConnectionDetails | |||
|
|
|||
| Ready Ready | |||
There was a problem hiding this comment.
Empty line here for consistency with DesiredComposed below
tenitski
commented
Jul 23, 2025
| r.Ready = v1.Ready_READY_FALSE | ||
| case resource.ReadyTrue: | ||
| r.Ready = v1.Ready_READY_TRUE | ||
| } |
There was a problem hiding this comment.
A bit of code duplication introduced with a switch (see SetDesiredComposedResources below).
It is minimal, moving it to a separate function does not really make the code tidier...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Exposes
.Desired.Composite.Readyfield added in crossplane/crossplane#6021 in function response.I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Tested with my own build of crossplane-contrib/function-go-templating#446 that implements crossplane-contrib/function-go-templating#153