Expose composite ready state in function response #446
+333
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexei Tenitski <[email protected]>
This was referenced Jul 23, 2025
Signed-off-by: Alexei Tenitski <[email protected]>
tenitski
force-pushed
the
composite-ready-state
branch
from
77c2b5c to
78e4d29
Compare
Signed-off-by: Alexei Tenitski <[email protected]>
Signed-off-by: Alexei Tenitski <[email protected]>
Signed-off-by: Alexei Tenitski <[email protected]>
tenitski
commented
Jul 23, 2025
| @@ -145,38 +145,74 @@ func (f *Function) RunFunction(_ context.Context, req *fnv1.RunFunctionRequest) | |||
| } | |||
|
|
|||
| // Initialize the requirements. | |||
| requirements := &fnv1.Requirements{ExtraResources: make(map[string]*fnv1.ResourceSelector)} | |||
| requirements := &fnv1.Requirements{Resources: make(map[string]*fnv1.ResourceSelector)} | |||
There was a problem hiding this comment.
Changed in latest function-sdk-go that this PR depend on
tenitski
commented
Jul 23, 2025
| @@ -83,3 +85,5 @@ require ( | |||
| sigs.k8s.io/structured-merge-diff/v4 v4.4.1 // indirect | |||
| sigs.k8s.io/yaml v1.4.0 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/crossplane/function-sdk-go => github.com/tenitski/function-sdk-go v0.0.0-20250723012926-634ed8aecb6f | |||
There was a problem hiding this comment.
Temporary depending on crossplane/function-sdk-go#218 while that PR is not merged and a new version is not released. Blocks merging of this PR, to be cleaned up and a proper version used instead.
There was a problem hiding this comment.
Discovered that bumping function-sdk-go to main version breaks function-go-templating:
crossplane/function-sdk-go#219
I believe the issue is on SDK side however it is possible that I did something wrong when fixing breaking changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Allows to set composite resource Ready state via annotation
gotemplating.fn.crossplane.io/ready, similarly how this is done for composed resources.Depends on the following pull request crossplane/function-sdk-go#218 which is temporary used as a dependency, to be fixed.
Fixes #153
I have: